unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: wyuenho@gmail.com, emacs-devel@gnu.org
Subject: Re: How to measure frame rate in fps?
Date: Tue, 1 Jun 2021 18:00:35 +0300	[thread overview]
Message-ID: <4fe7f7a7-7c23-25fc-2d59-f1290436f487@yandex.ru> (raw)
In-Reply-To: <83y2btzlui.fsf@gnu.org>

On 01.06.2021 17:43, Eli Zaretskii wrote:

> I know very little about the cost of the GTK tool bar redrawing: the
> code is in gtkutil.c, and it's full of GTK API calls.  Maybe the above
> times are explained and justified by that, I don't know.

Sometimes the times are high like this, sometimes they are lower. Could 
be it's another GTK bug, and there's nothing we can do, but it's 
probably a bug *somewhere*.

> I also am not sure the above faithfully reflects what happens in Real
> Life when Emacs has nothing to redisplay: I think you get the tool-bar
> redisplay triggered because the evaluation of the benchmark call
> causes it somehow.  How did you evaluate it, exactly?

Either using M-:, or with M-x benchmark like you suggested (only without 
prefix argument, to measure just 1 iteration). The results are similar.

>> Not so noticeable if it just happens once, but easily affects the
>> performance of code which performs "virtual" redisplay, such as
>> posn-at-point.
> 
> How do you deduce that posn-at-point triggers redisplay of the GTK
> tool bar?  It shouldn't, AFAIR.  posn-at-point and its ilk only
> simulate display of text, they don't care about window's and frame's
> decorations.

You're right, posn-at-point shows me different timings. Often enough as 
high as 12-15ms, which is not great for a low latency display, but the 
numbers don't seem to be tied to tool-bar-mode being on.

But we end up calling `redisplay` explicitly on a different code path in 
Company (when a backend talks to an external process, basically), so 
it's still affected by how long that takes.



  reply	other threads:[~2021-06-01 15:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31 13:03 How to measure frame rate in fps? Jimmy Yuen Ho Wong
2021-06-01 10:00 ` Arthur Miller
2021-06-01 11:43 ` Eli Zaretskii
2021-06-01 14:18   ` Dmitry Gutov
2021-06-01 14:43     ` Eli Zaretskii
2021-06-01 15:00       ` Dmitry Gutov [this message]
2021-06-01 15:35         ` Eli Zaretskii
2021-06-01 21:31           ` Dmitry Gutov
2021-06-02  2:29             ` Eli Zaretskii
2021-06-06  2:09               ` Dmitry Gutov
2021-06-06  6:11                 ` Eli Zaretskii
2021-06-06 12:00                   ` Dmitry Gutov
2021-06-06 12:36                     ` Eli Zaretskii
2021-06-06 16:48                       ` Dmitry Gutov
2021-06-06 17:19                         ` Eli Zaretskii
2021-06-06 23:31                           ` Dmitry Gutov
2021-06-07 12:33                             ` Eli Zaretskii
2021-06-06 18:10                         ` Stefan Monnier
2021-06-06 23:35                           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fe7f7a7-7c23-25fc-2d59-f1290436f487@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=wyuenho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).