From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Thu, 1 Sep 2022 14:48:32 +0300 Message-ID: <4f7fa9ba-2a85-3bc6-8f4f-bf59ee6598ca@yandex.ru> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <877d2pnqup.fsf@yahoo.com> <86zgfknc9a.fsf@mail.linkov.net> <87sflc91q7.fsf@gnus.org> <87wnao7l74.fsf@gnus.org> <0d5679a1-7635-53db-51c7-0ac0e35325d8@yandex.ru> <87mtbke7wf.fsf@gnus.org> <87ilm8e5am.fsf@gnus.org> <87k06nz9g8.fsf@gnus.org> <874jxrz5ai.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3719"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: Juri Linkov , Po Lu , "Alfred M. Szmidt" , eliz@gnu.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 01 14:27:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTjHr-0000mh-F8 for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Sep 2022 14:27:11 +0200 Original-Received: from localhost ([::1]:36306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTjHq-0003AN-6t for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Sep 2022 08:27:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTih8-00022z-S0 for emacs-devel@gnu.org; Thu, 01 Sep 2022 07:49:16 -0400 Original-Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:46071) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTih6-0001Fx-R9; Thu, 01 Sep 2022 07:49:14 -0400 Original-Received: by mail-wr1-x42e.google.com with SMTP id w5so5815117wrn.12; Thu, 01 Sep 2022 04:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc; bh=yaPFnjcqYeFVJ/6GZUehTM/g6egmoWuJ4THiJvoOhTg=; b=Hm8qNruCFhehb1bw4dsFldRKRr9oweqb2CHagWg5O1qkk0PdTMBUthf0rVv/8vwSuI K/CmNcJAaKaeLFVmXEAfZLxiYVve134pLrggkwD2IaHuaBmoChny4FjXjE752N6Mmsvt enaK30pWUx2pYRc6YhAOMU46gZM4KxUrl/wz6s0/RKK5r4OCrUaQdvaC30DK5DChP9Bp ukcZYTH9beh8n6QGxV8fyTUCLqzcxjFlzCkeu+kzDf3X7j3vESIIuurrjsCp6BymD/s1 6bGhcnUjhvWF12+uGy5PC1XxdTT2DR11czKcZIPpH3Uv5cYtzgVJwgyCiFZeE1Yj6rDO 3IIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc; bh=yaPFnjcqYeFVJ/6GZUehTM/g6egmoWuJ4THiJvoOhTg=; b=fY+WYJGnnYnSaOvWJm4b8Op9BI82UUV8duyW+W9RBA8rebtNxIDNowesnWGuhaldes E/Kyc3UaLm+unTLuwjvzaln1nJ2N+2SFDA/qJi3gMi9CBlLByVtf+CnTEw6HA8vQ5bvA ergrcOsxfHep4PBmN0/unpFM7zc1SurBq53+gp24dKQTBWjV8PUkJ+81YUlQkDYiatmt JZJlOWRZ7T4+UgPUzG+ARgZF9KufkU2K6awmBIwW1ZyXA/Zvg36ctUMHEcACG/FxKT/u OMCzqGXglTXvXZ2Ij4NkdQsT0J4tk/T20i5g0MylaWa4tmvPFwVA88rtXBzNmJclqLqB dwfQ== X-Gm-Message-State: ACgBeo0qcL0/A87t6xbT3S1bgDlk8JECtKm1iBszOx650HfyXEYODco/ KQO3AnhbxYVDkpjv5F8u+0Q= X-Google-Smtp-Source: AA6agR57nj1PSL1Bw9C1iB2MHCjcp2rETCdEjxBTFibX16QUk+3orzJ3Uk1z4m60nVINNpQOh9mRSw== X-Received: by 2002:adf:d1c9:0:b0:225:f98:d602 with SMTP id b9-20020adfd1c9000000b002250f98d602mr14669630wrd.419.1662032915971; Thu, 01 Sep 2022 04:48:35 -0700 (PDT) Original-Received: from [192.168.0.215] (buscust41-118.static.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id f14-20020a05600c4e8e00b003a5dbdea6a8sm6639555wmq.27.2022.09.01.04.48.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 04:48:34 -0700 (PDT) Content-Language: en-US In-Reply-To: <874jxrz5ai.fsf@gnus.org> Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42e.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294476 Archived-At: On 01.09.2022 14:45, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> The step of "applying the saved patch" relies on our Lisp code being >> correct and being able to handle any diff. It's not an outrageous >> assumption, but an assumption nevertheless. > Oh, I was assuming that we were assuming that we had "patch" installed > for this to work. I don't think that's unreasonable for new > functionality like this. I suggested this upthread but didn't get any affirmative response. This would be easier, yes.