From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: Mistakes in commit log messages Date: Sun, 16 Apr 2023 13:06:58 -0700 Message-ID: <4f45a223-535f-c9d7-90b8-5864b9adc7a7@gmail.com> References: <835ya5m4p0.fsf@gnu.org> <83v8i4arzt.fsf@gnu.org> <838rezardu.fsf@gnu.org> <319d616d-9230-0a82-331f-0f57488e4c80@gmail.com> <834jpm9s1g.fsf@gnu.org> <83v8i28b3j.fsf@gnu.org> <693285d2-e50b-289d-4f3e-ddd817ddc75b@gmail.com> <48d4dffa-cfa8-7949-3043-a1efa937902d@gmail.com> <838rew5lak.fsf@gnu.org> <5adfbf6f-fbcb-f4e8-3662-48bd5eb6a269@gmail.com> <9c8826af-a160-d36f-7577-2bc5ec0c2004@gmail.com> <265ac2c8-98bf-97db-2567-fce5db06577a@gmail.com> <83wn2cbcvw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18786"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 16 22:07:50 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1po8f7-0004mL-Pc for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Apr 2023 22:07:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1po8eQ-0008JT-12; Sun, 16 Apr 2023 16:07:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1po8eO-0008JI-B1 for emacs-devel@gnu.org; Sun, 16 Apr 2023 16:07:04 -0400 Original-Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1po8eM-00089o-Qz; Sun, 16 Apr 2023 16:07:04 -0400 Original-Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-514156b4976so1648359a12.3; Sun, 16 Apr 2023 13:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681675620; x=1684267620; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=HtnME8HEnpVTl/fUplvtqI8FJQ9d15T7KHdk4PbcQK8=; b=Fn1TGBm66zUoe8iqdrtM9VkU4eBNe8bHRERqoT4NDpyI/SP/3Qic/SxYavv7EHTQrp /pIHsUFfojXcqXouaFPqwBPp435ZqifZlpp2hSb5K025Qd2NOMT7J/y0E1nCStlGptWc TyYZ5Ng499RYI9g1O32SpfZyyh7w+nqtH9T7B3PSnD80TBKDBipMyDWt1nw7zNQiey0e BmgIa20aN895ku03gE/9HHvcEfoQsDToC8dlXndsOc0Y5bJWwdOq1v800ruZufnhxczb dm5IM/VGJZgZHaVmTOGBFCafPebGnKha5+FS6soxCM4y8/BM9XcuehcBkiIhsD38fQju 0OTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681675620; x=1684267620; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HtnME8HEnpVTl/fUplvtqI8FJQ9d15T7KHdk4PbcQK8=; b=E5xmYGzR3yTyn7+ve8ePkZzSOKuUu3+nRmQKITDFmkclPzJ0VqPkKHNWg9/ILbs/5h iztWpDHNo/vknyZwdaM/4EKpYUarEM8yEbwStw0nKCvms3JoECHB1+cMMWEkT2nUh9vb BXUO8pO12u163ZD+06rOpO5Y/Pjx7O6Rpbz+k9tyG5012hgySpZ4aGe20QZ6Rgc6K4Pi NPQagKgyqCJJDyEx7YW2rYMXgT+vfb04IXgHD1DNOxUnEVVEp8PGcrJYNi9yOlksz0vB +3OuiCZeeEArkZhOFwXenTJWkXoZIcJ0HNRmCNZ4A0CkTSWCgjqKW+Ms94QRogSnIXky cJTA== X-Gm-Message-State: AAQBX9fgrZ7FzHNDIWcYMuCcFPn5AYpCIAw6H9lvSjD+2+L1krSVH9nq l7sRpqQgznV2jZvAPGd/eQDh7ByuWMHoFQ== X-Google-Smtp-Source: AKy350ZBPnCXT5XXxsSY4KqFZ+cizphOc1Bf29iepZmCbY6SKOyirZGmsAGAPml7fszMc7w1mHHF/g== X-Received: by 2002:a05:6a00:1acb:b0:63b:23b0:a72e with SMTP id f11-20020a056a001acb00b0063b23b0a72emr18275444pfv.15.1681675620385; Sun, 16 Apr 2023 13:07:00 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d14-20020aa78e4e000000b00639eae8816asm6263954pfr.130.2023.04.16.13.06.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Apr 2023 13:06:59 -0700 (PDT) Content-Language: en-US In-Reply-To: <83wn2cbcvw.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=jporterbugs@gmail.com; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305348 Archived-At: On 4/15/2023 10:43 PM, Eli Zaretskii wrote: > And that's _a_lot_, no matter how you count them. Which should give > people here some idea why I raised this issue in the first place: I > needed to fix all those cases by hand while working on the pretest > tarball. Yeah, it's quite a bit more than I expected. Overall, I think the hooks are working pretty well now, and all the false positives should (hopefully) be resolved. Assuming there are no further issues, I'll merge them in a few days. Worst-case scenario, committers would just need to pass "--no-verify" to skip the hooks (or uninstall them temporarily), and then file a bug about any problems they find with the hooks. Another, more-general thing we could consider is to add a job on EMBA that tries to run through the automatable steps of making pretest tarballs, just to see if they complete without errors. Then we could set that to run, say, once a week, so we could identify problems earlier and fix them (e.g. by adding new Git hooks, or just sending a message to emacs-devel about it).