From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: master 5f9b5803bea: Fix zooming images in SHR Date: Sun, 23 Jun 2024 15:13:36 -0700 Message-ID: <4f280b27-80f6-c691-2a74-1b667160e7cd@gmail.com> References: <171912324641.7384.11296304660836747605@vcs2.savannah.gnu.org> <20240623061407.0C6DDC1FB5C@vcs2.savannah.gnu.org> <5f6b8e84-cd41-4229-ab22-64c931ff7966@app.fastmail.com> <50938116-7ba6-5625-94e0-fb55dfdc449d@gmail.com> <86o77rcvjz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21588"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jm@pub.pink, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 24 00:14:28 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLVTf-0005V6-5X for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Jun 2024 00:14:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLVSw-0000lv-Fv; Sun, 23 Jun 2024 18:13:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLVSv-0000lm-Hz for emacs-devel@gnu.org; Sun, 23 Jun 2024 18:13:41 -0400 Original-Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLVSt-0007xJ-V8; Sun, 23 Jun 2024 18:13:41 -0400 Original-Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1fa1a542466so6331035ad.0; Sun, 23 Jun 2024 15:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719180818; x=1719785618; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=S8xA1M2APe41FHkL3wis6V+W3WCb3AKU/kRDEIx3bSU=; b=huXYdtp6C41m2f+6O29VVjzLRw3thkztB/eQIB620fc8gNzhVGJNtsZVX1g4UPK0TB p2/62CeByTnm2B7nWmXYlnPuFUCVNkUmjyEuE7jj7jpEsngfIX5oKQLYAsit8PSjEAiq sI2T9GM/2Im0VxNyBrOn5afGYfdX/QxR1Mm1BJ5LzyVNFZw/t+aUsMHy0xchp71jkfxP Y7WHbqigLJbxAQqEPruhNAZNkOs2NyHj5ZW9dUpuE+wk+6sOwkVQXiG/jTw1/raeeDhI uymEog9gAwD3HuKeV6v5tifiMuibLhSlEZ8ADf0fm7Tlf/o/VOgVbRC8eMOP4bNzOICu fpIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719180818; x=1719785618; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S8xA1M2APe41FHkL3wis6V+W3WCb3AKU/kRDEIx3bSU=; b=Yhb5FqAZETdgDeI35eMpz7qPsMGfOHfHVitGEcnGJRcZySCL8/QbmsT6F2BM38+CWY kXwXXF/FgbfaG1U4pOwW6s1dGi8xYSvrb3M2Wi7zaUHKOxyxuVLdGVYsupnt4afti24w iVsNFl7XWl9hWA+8kprlONogMy/Re1iuT5HM57rq+y91O9EvpBnubBoJSLza02/vqtmj tdVqrQeq/MDRNPIt3IZ8Eac1SsALh38Tm8/XLYmliZKwnZGV0jZs+H4MyUvRRpad689f /LdKfMq1QhzOfIYOXxTdleQLHZy/VC1OPneKvwXTxByNYHeFgaCbPfX5dr6kjKuszsOd 9sTg== X-Forwarded-Encrypted: i=1; AJvYcCVPyVVjWp9yUfwZd5gnDN2QGX/eOVrGS09wDoJrLkCCDo8FAc/0CG1W149VlhfKg0h8aOGyI3dUqzdSbnYtPiWDLA5j X-Gm-Message-State: AOJu0YzMXlgxn3Po3bpsERu/IqxktolPqGJpuCOtqjLva2CKsboayTCk d3ME5qmuRAJM2VVtPrZdUjMx6FAcoHA2k71kNTOHN6ZsuLHDSs5uWT68EQ== X-Google-Smtp-Source: AGHT+IGk1bpmH85dJ+qzokxhCI/LQt8bHZZ2o7hMb2cRc5Ttdvdd7LR8oDEVVyFGVdIGU8CkACTEiA== X-Received: by 2002:a17:902:d4cc:b0:1fa:2c79:74fd with SMTP id d9443c01a7336-1fa2c7975cbmr21482995ad.41.1719180817778; Sun, 23 Jun 2024 15:13:37 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f9eb3c5f87sm49638535ad.166.2024.06.23.15.13.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jun 2024 15:13:37 -0700 (PDT) Content-Language: en-US In-Reply-To: <86o77rcvjz.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320581 Archived-At: On 6/23/2024 12:23 PM, Eli Zaretskii wrote: > Thanks, but the test fails for me on MS-Windows: > > Test shr-test/zoom-image condition: > Info: image with alt=nil > (error "timed out waiting for condition") > FAILED 3/4 shr-test/zoom-image (5.053704 sec) at lisp/net/shr-tests.el:136 > > (The other test failed as well, but I fixed it.) > > Frankly, I have no idea why it fails, because I only vaguely > understand the idea of the test. Feel free to ask questions or > suggests what to test. Could you try commenting out the "(inhibit-message t)" line in the test and rerunning it? My guess is that on MS-Windows, something goes wrong when inserting the image into the buffer, so 'shr-zoom-image' can't find the image. (For reasons I'm not sure about, when 'shr-zoom-image' fails to find an image, it just prints a message instead of signaling an error.)