From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 716b468: Extend `file-notify-test02-rm-watch' Date: Wed, 5 Apr 2017 22:59:40 -0400 Message-ID: <4f1308e2-0b49-ef3e-fae7-02bdd8dc75ef@cornell.edu> References: <20170322131610.22658.57119@vcs0.savannah.gnu.org> <20170322131611.5FF7D20E17@vcs0.savannah.gnu.org> <70055ee8-c1cb-30d2-8a0b-38637adad497@cornell.edu> <87mvbutvo6.fsf@luca> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1491447634 4131 195.159.176.226 (6 Apr 2017 03:00:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 6 Apr 2017 03:00:34 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 Cc: Michael Albinus , emacs-devel@gnu.org To: Andreas Politz Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 06 05:00:27 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvxem-0008Mb-JX for ged-emacs-devel@m.gmane.org; Thu, 06 Apr 2017 05:00:20 +0200 Original-Received: from localhost ([::1]:43233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvxes-0005sj-Js for ged-emacs-devel@m.gmane.org; Wed, 05 Apr 2017 23:00:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvxeC-0005To-46 for emacs-devel@gnu.org; Wed, 05 Apr 2017 22:59:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvxe7-0006wZ-9T for emacs-devel@gnu.org; Wed, 05 Apr 2017 22:59:44 -0400 Original-Received: from limerock04.mail.cornell.edu ([128.84.13.244]:39636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvxe7-0006wF-47 for emacs-devel@gnu.org; Wed, 05 Apr 2017 22:59:39 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v362xYE4013255; Wed, 5 Apr 2017 22:59:34 -0400 Original-Received: from [192.168.1.4] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v362xXtM007841 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 5 Apr 2017 22:59:34 -0400 In-Reply-To: <87mvbutvo6.fsf@luca> X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 128.84.13.244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213690 Archived-At: On 4/5/2017 5:02 PM, Andreas Politz wrote: > Ken Brown writes: > >> This may be another of those timing issues that we've dealt with >> before [...]. > > I think it is as well. If cygwin's file-notify back-end runs on a polling > timer, we need to make sure that it has acknowledged the file's > existence before we delete it. Maybe you could try out the following > patch. > > > > diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el > index 54e7ebfc0e..9b5c751021 100644 > --- a/test/lisp/filenotify-tests.el > +++ b/test/lisp/filenotify-tests.el > @@ -425,6 +425,7 @@ file-notify--test-make-temp-name > '(change) #'second-callback))) > ;; Remove first watch. > (file-notify-rm-watch file-notify--test-desc) > + (file-notify--test-read-event) > ;; Only the second callback shall run. > (delete-file file-notify--test-tmpfile) > (file-notify--wait-for-events No, it still fails. Ken