Re: git+master: c6e6503900534d939dd94b812563c27f22c49b7d crash when using gnus

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Noam Postavsky wrote:
> the autoconf manual recommends setting variables (apart from
> CONFIG_SHELL) in the ./configure command line rather than the
> environment.

Quite right, and the Emacs doc mostly follows that advice, but there were a few 
cases where it still used the older convention of setting CFLAGS in the 
environment. I fixed the cases I found by installing the attached into master.

[-- Attachment #2: 0001-Advise-CFLAGS-operand-not-in-environment-when-config.patch --]
[-- Type: text/x-patch, Size: 2559 bytes --]

From bf12cc6c7830937b4c1a3df46294e74bea749a5f Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 29 Apr 2018 09:28:11 -0700
Subject: [PATCH] Advise CFLAGS= operand, not in environment, when configuring

---
 etc/DEBUG    | 3 ++-
 etc/PROBLEMS | 2 +-
 nt/INSTALL   | 6 ++++--
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/etc/DEBUG b/etc/DEBUG
index a779295..49764fc 100644
--- a/etc/DEBUG
+++ b/etc/DEBUG
@@ -16,7 +16,8 @@ make the debugging easier.  Here's the configure-time options we
 recommend (they are in addition to any other options you might need,
 such as --prefix):
 
-  CFLAGS='-O0 -g3' ./configure --enable-checking='yes,glyphs' --enable-check-lisp-object-type
+  ./configure --enable-checking='yes,glyphs' --enable-check-lisp-object-type \
+    CFLAGS='-O0 -g3'
 
 The CFLAGS value is important: debugging optimized code can be very
 hard.  (If the problem only happens with optimized code, you may need
diff --git a/etc/PROBLEMS b/etc/PROBLEMS
index d19efaa..8fb3d74 100644
--- a/etc/PROBLEMS
+++ b/etc/PROBLEMS
@@ -126,7 +126,7 @@ This version of GCC is buggy: see
 You can work around this error in gcc-4.5 by omitting sibling call
 optimization.  To do this, configure Emacs with
 
- CFLAGS="-g -O2 -fno-optimize-sibling-calls" ./configure
+ ./configure CFLAGS="-g -O2 -fno-optimize-sibling-calls"
 
 ** Emacs compiled with GCC 4.6.1 crashes on MS-Windows when C-g is pressed
 
diff --git a/nt/INSTALL b/nt/INSTALL
index d2e5e99..6706942 100644
--- a/nt/INSTALL
+++ b/nt/INSTALL
@@ -52,7 +52,8 @@ build will run on Windows 9X and newer systems).
      You can pass other options to the configure script.  Here's a
      typical example (for an in-place debug build):
 
-       CFLAGS='-O0 -g3' ./configure --prefix=/d/usr/emacs --enable-checking='yes,glyphs'
+       ./configure --prefix=/d/usr/emacs --enable-checking='yes,glyphs' \
+         CFLAGS='-O0 -g3'
 
   3. After the configure script finishes, it should display the
      resulting configuration.  After that, type
@@ -461,7 +462,8 @@ build will run on Windows 9X and newer systems).
   A few frequently used options are needed when you want to produce an
   unoptimized binary with runtime checks enabled:
 
-     CFLAGS='-O0 -g3' ./configure --prefix=PREFIX --enable-checking='yes,glyphs'
+     ./configure --prefix=PREFIX --enable-checking='yes,glyphs' \
+       CFLAGS='-O0 -g3'
 
   Once invoked, the configure script will run for some time, and, if
   successful, will eventually produce a summary of the configuration
-- 
2.7.4