From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "David Robinow" Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50 compile problem on Windows XP Date: Thu, 4 Oct 2007 20:46:22 -0400 Message-ID: <4eb0089f0710041746s6bc7e135w2fa95f8673f9abc@mail.gmail.com> References: <47035169.8070402@gnu.org> <4703869F.6070909@gnu.org> <47038922.10105@gnu.org> <4705652C.5070803@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1191545206 30211 80.91.229.12 (5 Oct 2007 00:46:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 5 Oct 2007 00:46:46 +0000 (UTC) Cc: Sridhar Boovaraghavan , emacs-devel@gnu.org To: "Jason Rumney" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 05 02:46:42 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IdbKv-0003Cr-PP for ged-emacs-devel@m.gmane.org; Fri, 05 Oct 2007 02:46:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdbKq-0002y8-EB for ged-emacs-devel@m.gmane.org; Thu, 04 Oct 2007 20:46:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IdbKl-0002tA-5k for emacs-devel@gnu.org; Thu, 04 Oct 2007 20:46:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IdbKj-0002rY-PL for emacs-devel@gnu.org; Thu, 04 Oct 2007 20:46:26 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdbKj-0002rO-Eq for emacs-devel@gnu.org; Thu, 04 Oct 2007 20:46:25 -0400 Original-Received: from nf-out-0910.google.com ([64.233.182.185]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IdbKj-00036k-6A for emacs-devel@gnu.org; Thu, 04 Oct 2007 20:46:25 -0400 Original-Received: by nf-out-0910.google.com with SMTP id f5so319418nfh for ; Thu, 04 Oct 2007 17:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=n+xOUKJi9BVwC2zNBlnoQrOTSaxyHzsqHxRRERjeq6A=; b=AinmMGDAPSpk5qhzpaGI4xwBEmDCj6N6rBZzSO2y+tMJAv+CEzxxUuZeuKY2cE/5mx0g5m5I1gdgzzyj94A6dSLh4Hob523NH6Md5VSLrvrUqgoinJnJf4/+vPmJQhkmzcfuUKiBak6eeghMd/WJQHGAeM0XhqRR59sZCl997q0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=rGkrYAgC31pFDJV7TtX3K4U4kvdUv0tBxmVxaewzerGv3+Lm5lwXoj/yJCWSGUPul03OwY/ZsjYAtQaAkYy1pXOCbmsaAUvmEWjNHUTXR78Cs3+pUeSQDSxZQnCmNVl6rcC//YzrVDC8iUkgCxBWg7lL7N7pFvt6A0HLwMbQal4= Original-Received: by 10.86.70.8 with SMTP id s8mr1998481fga.1191545182830; Thu, 04 Oct 2007 17:46:22 -0700 (PDT) Original-Received: by 10.86.97.5 with HTTP; Thu, 4 Oct 2007 17:46:22 -0700 (PDT) In-Reply-To: <4705652C.5070803@gnu.org> Content-Disposition: inline X-Detected-Kernel: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80259 Archived-At: On 10/4/07, Jason Rumney wrote: > Sridhar Boovaraghavan wrote: > > Thank you for looking into and diagnosing the problem. I have moved > > the inclusion of above "lisp.h" in the affected files and > > here's a patch against HEAD that solves this issue. > > > There are several other files that include stdlib.h after lisp.h > conditional on WINDOWSNT too. Does that not also cause the same problem? > Also msdos.c includes lisp.h before stdlib.h, so there could be a > problem there too. > > I think it is better to remove this definition from lisp.h and include > stdlib.h in the files that need it. But perhaps there is a good reason > not to do that in the first place, so I'll wait and let others comment > on my mail from yesterday before making that change. I agree with Jason. Take 'abs' out of lisp.h I used to wonder why "abs" wasn't defined in math.h, since it seems an obvious place to put it. Apparently somebody at Microsoft was thinking the same thing. Bad idea. Anyway, a good rule is: don't use "abs". It's not that complicated an algorithm.