From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Making project-files the "canonical" generic, was: Re: [Emacs-diffs] master 55ec674: * lisp/multifile.el: New file, extracted from etags.el Date: Sat, 12 Jan 2019 04:10:57 +0300 Message-ID: <4e729d1e-bb31-455f-fd44-e99ae5a6b9fa@yandex.ru> References: <20180922154639.23195.66360@vcs0.savannah.gnu.org> <20180922154640.9D58220310@vcs0.savannah.gnu.org> <54108dbc-9d12-06ff-3f1d-151118e9b234@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1547255345 18096 195.159.176.226 (12 Jan 2019 01:09:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 Jan 2019 01:09:05 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Thunderbird/65.0 Cc: Stefan Monnier , emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 12 02:09:00 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gi7nG-0004XY-Ie for ged-emacs-devel@m.gmane.org; Sat, 12 Jan 2019 02:08:58 +0100 Original-Received: from localhost ([127.0.0.1]:42067 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gi7pN-0001Qs-0l for ged-emacs-devel@m.gmane.org; Fri, 11 Jan 2019 20:11:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gi7pG-0001Qj-OY for emacs-devel@gnu.org; Fri, 11 Jan 2019 20:11:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gi7pG-0003L2-3T for emacs-devel@gnu.org; Fri, 11 Jan 2019 20:11:02 -0500 Original-Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:33555) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gi7pF-0003Jd-Rp for emacs-devel@gnu.org; Fri, 11 Jan 2019 20:11:02 -0500 Original-Received: by mail-lf1-x130.google.com with SMTP id i26so12118681lfc.0 for ; Fri, 11 Jan 2019 17:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=r6t2rolhSlijeX5uO+w1TnJdlFLyHgB4pnaYoNTZ1eE=; b=phuBeY9IdBzqcY6eY2g+XCN+wnKV+fCE9gEXh4KDzhncyfK8+E5yi7OWF/2eTj5r7Q gTBA+dX9WrKAyNTOiglwG04bBvamfTnjqCwvzE6E/sUwebebj01vNHvKwNVUX8ywS6Mv sdeNJzG6/8EcmQ8SFZUCaDbH7MWilK7JV8VlZg3CEHMdqF5CiHS4m0u33SvjJ10YjBVL GPOoeq7oedcKwD8Ejx+o+RUN7dnox1fJSu98kVY+b0EYc8JcEHypNqTKIeHnfP/nPzQX D43ktngWEJ1bbl6XQzi32bIb2N+DJAwKQ4weA0jr+FI3AEqGbJVGwY4lHWLJaiDuuKGe D2mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=r6t2rolhSlijeX5uO+w1TnJdlFLyHgB4pnaYoNTZ1eE=; b=UmqN++a170m//Ls07LHDlGrnXyVcHcgjVF2m/Ugqa3TVl8AS6esiRxNNxfCVGcUBb1 X50nyFFfHF2XeaxTQPnRR2Jw7+X5gLMRaw6JJwpsI/xabjLUhbEnJDJV4QsbD43P/LjQ CpiHcGjOdk6Tv9qmSQlFZ5N/w90uZhf8GDKrMATNwHVZpP1ctTJ2Xmf5+2MP1YrYYfoq 7kmAvtlBag5thiAJCKxzCIQRx9F4LaPTbjI7EN1pPSRicP8KIdunU/63MI2rWP6yI/sN imyHYVd0XxIshxfQgVjvoe6GTLIdplqrLgxtFnWl9AlOWf5JA8VTDJqrUYnomFlpKgAF cQjw== X-Gm-Message-State: AJcUukfpYUr8GuckHrRHfBH1hvxjf5sx1CZ0iGxNxHCZciGxv2xSkOVR BzPBDr1IY8hQ3y86fMIzRYoKi9j3MVw= X-Google-Smtp-Source: ALg8bN7wUgORMUVL2XQzcv3w611/m9owgO6oQ/T/uh6vRXkb7ZbvcuYveQyEWiYiTEdJODLa19Gdkg== X-Received: by 2002:a19:1a14:: with SMTP id a20mr8900586lfa.1.1547255459360; Fri, 11 Jan 2019 17:10:59 -0800 (PST) Original-Received: from [192.168.0.108] ([79.175.3.69]) by smtp.googlemail.com with ESMTPSA id g15sm14759712lfb.1.2019.01.11.17.10.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Jan 2019 17:10:58 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::130 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232314 Archived-At: Stephen, hi! Since it was your initiative that eventually brought us project-find-file and project-file-completion-table, I'd like to ask: Did you end up ever using it and/or integrating it with ada-mode, or in some other third-party code? If so, do you see any particular benefits in keeping project-file-completion-table a generic function instead of reimplementing it on top of the (somewhat) newly added project-files generic? On 27.12.2018 17:39, Stefan Monnier wrote: >>> Not sure what you mean by "keep them in sync". >> Making sure to implement them in a compatible fashion. My point is, it's >> probably better to leave just one if the other can (almost?) always be >> efficiently implemented in terms of it. > Right. But I'm not sure which one should be the "canonical" one. > Currently, the "canonical" one is the completion-table, and the > files-list is defined based on it (while it's current definition only > handles flat completion, that could be improved).