From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: pull requests Date: Sat, 28 Mar 2020 19:14:11 +0200 Message-ID: <4ceaa8ac-9a19-d874-51d6-8056bcb46b2c@yandex.ru> References: <87mu87ji39.fsf@dick> <87v9mvp2ms.fsf@blind.guru> <87d093f6lj.fsf@dick> <87369yc79r.fsf@dick> <83mu828c7d.fsf@gnu.org> <7b0e82fd-8928-26d2-4bed-331593685f36@gmail.com> <83h7ya7wne.fsf@gnu.org> <8b7d5a28-8193-cd12-bb47-b70c7eee6db5@gmail.com> <83eetd962o.fsf@gnu.org> <281f88c3-ea09-3486-5532-5084881bf38b@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="26136"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 Cc: eliz@gnu.org, cpitclaudel@gmail.com, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 28 18:14:49 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jIF2n-0006hA-Cl for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Mar 2020 18:14:49 +0100 Original-Received: from localhost ([::1]:57338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIF2m-0000XZ-DV for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Mar 2020 13:14:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58804) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIF2G-000064-VC for emacs-devel@gnu.org; Sat, 28 Mar 2020 13:14:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIF2F-0003QL-A1 for emacs-devel@gnu.org; Sat, 28 Mar 2020 13:14:16 -0400 Original-Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:35384) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIF2F-0003Ou-1k; Sat, 28 Mar 2020 13:14:15 -0400 Original-Received: by mail-wm1-x329.google.com with SMTP id f74so5214358wmf.0; Sat, 28 Mar 2020 10:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zuBX+3bh5nWtgQdE8NEjjTBxHguPamAtJbsSriLV91s=; b=HnG53Cq9bOtFTy08NfT+JM7VBKeKCKrO2L5+34ATUCJ4TsSu2m625/IS9Z3j5h6n9a U2bkrv6RTKbERSTbGgQKltZYE+9UIIunq5u4iuSSiHz8IgK/5F/rBaZ8f/LeLBOK52Z2 VbwQVcprigluNBr6SCUoBSohWETdYAmihRftMx21OHlqUvlf+fKsspleW3yN8J0ZxaMm SeT/PW1wi+Yw/BAoTTePdkEib/EDVuRzstnm6MqAEyHyMk3DjiB5ZhtGn5nxiYigPLa5 MRjGJKqJcKBVuZ1BvZ8bJW3n11opYn8Q3P+UKbMCzQidzLsT0wqyT/m4IfnSLD98taT6 jBdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zuBX+3bh5nWtgQdE8NEjjTBxHguPamAtJbsSriLV91s=; b=JW5PFkLNesghzBIGvGHX+Qz7bPJ6F+Y2gCPo594T6+lNKkarHhUej9uPSZ0EApNYsS RSATz3FR5EgkSLeWoLmlB0sCqIxP/4d0kCy858XX3iGYjehzFbjzFQBPU8lvXX4RXRaQ 3+FvXyBvqLNxDqT5ayGkHlsGItRH4NO17HUlCZZXWyFlkTG/P6a+hZg+ZvvD9rim/++U utk0rHQ+3rn0HudIJFxiKYYKWsfaqt1jwNvlww2QHxfabP2nLWw2Qu7bn3+er/Tr4171 WKWE16qQ6UhMHnNBmaWgSIibyM7P3t1PLoNs/qzxvlR/oseQdYyoiJla/ZA+T8xyCFeR AVSQ== X-Gm-Message-State: ANhLgQ01gxWDUCteefCLeeADiDqziik0dllv2Soz8DFBGB9jKagsLskv iWuAGW+SdmHDmHkxKSrJEmNSUhep X-Google-Smtp-Source: ADFU+vup3gLnZ2EUNCidwuQKYG9mA6ggZUj3PnbqOdh+GigPAVJmeyLf75veBh6f+Tzq5XXTNNysHA== X-Received: by 2002:a1c:491:: with SMTP id 139mr4650006wme.21.1585415653428; Sat, 28 Mar 2020 10:14:13 -0700 (PDT) Original-Received: from [192.168.0.2] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id f22sm20094450wmf.2.2020.03.28.10.14.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Mar 2020 10:14:12 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::329 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245893 Archived-At: On 28.03.2020 04:46, Richard Stallman wrote: > [[[ To any NSA and FBI agents reading my email: please consider ]]] > [[[ whether defending the US Constitution against all enemies, ]]] > [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > > That section is literally "contributions under consideration", > > That is a statement of intentions, not facts. Emacs developers > would know those intentions, but other Emacs users might have no > idea about them. That's why we have forges, with self-explanatory web interfaces and even integrated help for new users. > why would > > anyone think it's the project code already? > > Why wouldn't anyone thing so? Are you proposing to display a message > of explanation whenever someone tries to view the code in a pull request? 99% of the users who would be looking at them, would be doing so through the web interface of the force software. And at that web page it would be made apparent that the user is looking at a pull request. > Suppose A sends B a URL pointing to a branch with non-installed > patches. If A doesn't warn B; if A is too terse and does not make the > point clear, B will not know it is non-installed. B will only see > that it is in the standard GNU Emacs repo. When you were talking about hiding PRs from non-developers, you meant hiding in the web interface, right? Because it would be hard to hide them in the mailing lists, for example, considering they're all public. Anyway, if the branch is not called master or emacs-xx, then it's relatively obvious that it contains some code that is yet to incorporated. > This is asking for big trouble. Versions of Emacs that by policy > we should not be distributing could start being distributed in that way, > and no responsible person would ever be asked whether to do this. As per above, I think it would be hard to mistake a non-official branch for an official one. But that brings us to the question of whether we would allow unauthenticated users to create new branches in our forge. The previous discussion concluded on "probably not", and then the situation is not different from the current one: pull requests (or "merge requests") would be created only by the current developers who have commit access. But if we manage to support merge requests from contributors without commit access, and do it without external repositories, we could just as well mandate that all such branches have names prefixed with "merge-request/", and that will avoid any confusion. Also, if any branches in our repo end up containing really problematic code, I'm sure that can be dealt with on a case-by-case basis.