From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: wait_reading_process_ouput hangs in certain cases (w/ patches) Date: Tue, 13 Mar 2018 17:56:17 +0200 Message-ID: <4c9d1e14-440d-580c-ad93-ca3e6936c366@yandex.ru> References: <709614e8-1937-07c1-f554-b453ed4f3d4a@binary-island.eu> <7550438b-9fd4-d374-e571-8bb16456cad5@cs.ucla.edu> <797d0e16-1bae-50c2-35f8-05489ffce935@binary-island.eu> <83tvugdiu5.fsf@gnu.org> <877er5s0xv.fsf@gmail.com> <4e4c72bb-295d-81e1-e4ed-cad256bca83c@binary-island.eu> <87zi3v9461.fsf@gmail.com> <87k1uy8x68.fsf@gmail.com> <6d1970af-8c5c-20ba-be09-0b9aa757d663@binary-island.eu> <13b3e003-d12b-33a7-3ebe-c07b017a7cc0@binary-island.eu> <87r2oow3uc.fsf@gmail.com> <2ab717c8-8d4f-ff34-04db-63b1c8b83dd4@yandex.ru> <87muzcasho.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1520956620 12051 195.159.176.226 (13 Mar 2018 15:57:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Mar 2018 15:57:00 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 13 16:56:56 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evmIJ-00030l-87 for ged-emacs-devel@m.gmane.org; Tue, 13 Mar 2018 16:56:55 +0100 Original-Received: from localhost ([::1]:40721 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evmKM-0000w7-4F for ged-emacs-devel@m.gmane.org; Tue, 13 Mar 2018 11:59:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evmHr-0008AF-3v for emacs-devel@gnu.org; Tue, 13 Mar 2018 11:56:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evmHm-000163-AB for emacs-devel@gnu.org; Tue, 13 Mar 2018 11:56:27 -0400 Original-Received: from mail-wr0-x231.google.com ([2a00:1450:400c:c0c::231]:43770) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evmHm-00015e-2x for emacs-devel@gnu.org; Tue, 13 Mar 2018 11:56:22 -0400 Original-Received: by mail-wr0-x231.google.com with SMTP id o1so214097wro.10 for ; Tue, 13 Mar 2018 08:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9ba1j2ZktFir7bFcukMZj8Tz9mtVpBw3BKEraRZ9a5o=; b=d4NZYXAt4unWCWemW8CJ2ejyLGjR4uXCJeUgow4XhSIc7cZY/8I33xua4IdyeLXLPx RzoovOaG5XnE/pTkoLQlg2dw3T3PZ3SZM4GKgZ8Va5Oy9JvQmJ/9on7ev+ecrErh3URH qocE+ZufCWupoR+fQECxixKqmUIYYNo3H8lQo0rC5kR/edWGpTik4qRnna34ETthxk5e 8xt9wG3hZveUaChEAPPjzpykTcFjaB0ePHdLSqFlTA/zmKReaTcwR6aE4LBhSF6eFMgd Z5JAfbt3qh281I3gqh5LA/iG+KCI3m5UgouokX3rjdxUanzhLmJe2mGOMlrgb6HIhB+r IRwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9ba1j2ZktFir7bFcukMZj8Tz9mtVpBw3BKEraRZ9a5o=; b=RjXiTBvtiE9DHU7/XRIq2tpe6pB2enWoPHZAJDCSSzooiXsCv5sUzMuwB2e9Pc2ftj 3k+72z8x9pJuXhy3BCUJ7yrWc/+HpqrKUR2VMHwlRB2ubcPQCcdwOLaPURDLXb7G/Xe+ KvkY0loO5uq5ioD3RyNerYo7zIf/DGqDgsjvoQO4X97ciEcY4viHDBhDklZ/ePqytSuS 0WEqXdw4JM9oMZD4kjh8fSOEufsCetQmeqD26IBBhI5TpHOvXXjTfQLNhq4fJStHTUTe zV8kos7gx4c9H/IrsjXPeJnewtIBJ6YYS5x8Mo8lHqVVC4sygL2+jJ4Gas+c1gC4bJgI D4LQ== X-Gm-Message-State: AElRT7FyvkrxLcifryyfj0+RD8TRaY/vUNPce+inMHEnZjt5vUUzqmyN evunYhyapcAJBZXkkCIUSN64vo66 X-Google-Smtp-Source: AG47ELsxed99Sa9KolNLcwvD5K3efJ3oIfKi6W4Je4JYd2hUSNwP0vkkn5QLYXRMNvYmmJg+F3lQQg== X-Received: by 10.223.164.20 with SMTP id d20mr1082253wra.136.1520956580488; Tue, 13 Mar 2018 08:56:20 -0700 (PDT) Original-Received: from [192.168.0.174] ([212.50.99.193]) by smtp.googlemail.com with ESMTPSA id n49sm680749wrn.90.2018.03.13.08.56.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Mar 2018 08:56:19 -0700 (PDT) In-Reply-To: <87muzcasho.fsf@gmail.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223694 Archived-At: On 3/13/18 5:46 PM, Robert Pluim wrote: > It got caught before it got committed, so not that bad. I mean the general possibility of having somebody who comes later reverse the fix. For some code the odds of this happening are fairly small (via architectural decisions, or segregating a fix into a separate unit of code, or maybe just commenting profusely). Not so in this case, apparently. >> Fiddly, hard-to-reproduce misbehavior is the ideal target for >> regression tests, IMO. > > My current test-case for 21337 is 'visit a bunch of files, make sure > global-auto-revert is turned on and auto-revert-use-notify is t, run > Gnus (or anything else that makes TLS connections), wait for errors to > be signalled by inotify'. I don't know how to write a regression test > for that. Maybe there's a way to simulate the critical conditions more directly?