From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Fri, 28 May 2021 15:55:38 +0200 Message-ID: <4b4a9e27-cedb-856b-9244-b9dc980c1664@daniel-mendler.de> References: <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87y2c5nhsr.fsf@mail.linkov.net> <87h7irss50.fsf@mail.linkov.net> <43d1599e-2ba9-2efb-45c3-76c67d29a69d@daniel-mendler.de> <87tumrgqrb.fsf@gmail.com> <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <874kenulu2.fsf@gmail.com> <5f032d77-670e-e83e-fa37-f0a57e08e166@daniel-mendler.de> <87v973t5q3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10722"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , emacs-devel , Stefan Monnier , Juri Linkov To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 28 15:56:21 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmcyK-0002aO-Ew for ged-emacs-devel@m.gmane-mx.org; Fri, 28 May 2021 15:56:20 +0200 Original-Received: from localhost ([::1]:39556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmcyJ-00034L-IE for ged-emacs-devel@m.gmane-mx.org; Fri, 28 May 2021 09:56:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmcxm-0002Oo-8y for emacs-devel@gnu.org; Fri, 28 May 2021 09:55:46 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:36105 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmcxk-000174-2z for emacs-devel@gnu.org; Fri, 28 May 2021 09:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tRmG1033EDKQPNxL0bePf/Kl2SJsu4oibg9NfrG40Jc=; b=coHLKptYAyjUyJqLecj6ogMygD Emv5fKP3ZMstiB21uijF+IECsjZGGqZeVaiDEV6OiQX7yJeCA26r1//MGDPsIncQPXHq+xO48yrtK bnG/8fvfEavV7RVATNi/886cUHoxEIKKDeLC1uayh+LI1PP+6o5h+nhROi6OtnZlZBX8=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270002 Archived-At: On 5/28/21 3:17 PM, João Távora wrote: > If some filtering inside the marginalia is needed, just make the > marginalia field be a plist instead of a flat list. > Dmitry's completion-info-columns-function is the same idea in a separate > API. Also works, but I prefer this one, as columns is constraining > design on the backend side. > > So no, you did not address this. You enforce a strong coupling between > backend and frontend. > > > Check again.  You are talking about the introduction of a `marginalia` field. Such a field should not be necessary. The frontend should not have to know about the existence of a `marginalia` field. What you probably want to say here is that the name does not matter and we could also call this generically `auxiliary-annotation-columns` and then the frontends could support this field containing another list of fields if the frontend likes that or not. > For example in Marginalia we take some care to not compute particularly > expensive annotations. > > > Which is a drawback. A frontend with async capabilities can choose to > request the expensive ones, too, for example.  Of course. I am not against such a query based API. But one should take into account that other expensive metadata can be provided via other query functions. There is no advantage in requesting some `expensive-field` from a `resolution/decoration-function` in contrast to calling an `expensive-field-function` which is specified in the metadata. I fail to see what the hypothetical `resolution/decoration-function` improves. The use case with the columns I described won't be supported out of the box. Prefix/suffix is supported with the only change over the affixation function that the prefix/suffix must be requested explicitly. Daniel