From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Sun, 2 Jan 2022 18:09:15 +0100 Message-ID: <4b1c3a53-eb09-329f-9348-51d321b2893d@gmx.at> References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> <871r1v8nhf.fsf@gnus.org> <83ilv7jqm7.fsf@gnu.org> <6a9cd581-1630-4a95-62c4-419603561072@gmx.at> <3499cedf-b170-3045-873d-d45d2972ae13@gmx.at> <0f492ac4-4167-5448-2c74-a5f67950eae4@yandex.ru> <2de2323b-6d34-9263-776b-dbeff036f8f4@gmx.at> <87zgog68ni.fsf@gnus.org> <8dfc6f22-d331-e7c1-b536-2d374197528f@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1959"; mail-complaints-to="usenet@ciao.gmane.io" To: Madhu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 02 18:10:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n44NK-0000O8-AI for ged-emacs-devel@m.gmane-mx.org; Sun, 02 Jan 2022 18:10:30 +0100 Original-Received: from localhost ([::1]:44836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n44NI-0007Dp-OG for ged-emacs-devel@m.gmane-mx.org; Sun, 02 Jan 2022 12:10:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n44MJ-0006RT-Ft for emacs-devel@gnu.org; Sun, 02 Jan 2022 12:09:27 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:52983) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n44MG-0002Ln-Ar for emacs-devel@gnu.org; Sun, 02 Jan 2022 12:09:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1641143356; bh=5u3mhK5uh307fJOGy9Q2tGuJvMEqladNTTP5h4skslI=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=W5Sup91e8MX4OUbd49kKB9fGkAZk+3IhGU7NELX2Idgvzsse/jeIHkK9sS3kH0+hX O8aggCsbMKbXx5N6bEgfDgdfCM+NNh+E+NWOucw6NrzV6FT8vf3qMBkMaysUlzx5i3 ml9pEvt/Bm8pZTe3w057+A1Bp8jvGsW7ClGy+ZEI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([212.95.5.26]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2V4P-1mPSx113j5-013sun; Sun, 02 Jan 2022 18:09:16 +0100 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:Ooevx/pgHzEaHWdrasWKicTr4ihGakEsgxBTEgfqHjWkjl+NS8S kU3tKumJbWaaTGg5J1UXjLKawnoj292URsgyQlNHhJ84e0JAQ/DPAjQrUysXBUOmvHD1F7g AKjvSOfrdfJkwu5QrQTTh3Q3cXmfBtG/iNIJMTtVQpF2HTnE8pBoexFRjQFKzd/cKG/KoFJ oCYol1FmJnlDR2RT6uFtg== X-UI-Out-Filterresults: notjunk:1;V03:K0:xtEqSHKYuwA=:8Q9jRZL/uXgUJN4Gv5YyRX 0xvYne+3CC51yUg+NM/Eb1DwHOE8YcVo4wJwq256817+MEx+q5txP0UUXSLjKz3vbsXOUs67h 7YoBfcsquaIkCo4UpAw/j6PIiHYZQVvwLYqEpg6VaOeFAoHlB+TkuKqflQYkwo7kM790Qjl2n mJIUK3sqRL16m0C/YxAq66/seX6yYRRCspFzNy2B8jL7R0hAU0d1tXdh5im60ZdqAUmWLDSjd OncrnysloPxNvRiOK8hRi2Rad2E1vulTFLfK4oTDDMU7LxGIiFLbYWhKdeAquBnOiSc6UwoGf Lf2Y3JS24wvHbMsLHRHNQVo2zKccOc0HOf3Kh1QQSEcrdO0E6dm6DgZbIE97LbUFWB1aUAccp RDgFAJBHB69tE1uuiQx2w5ezooZzjH7W6P6UpMjC9FRuvAHQ5WuCSQQT8OGJpGCB8ruXfW8cL snf7d/C8j2sI3EEtYAb/imH/NKMnXsNYVARpckJFjcNWSOejbVoCBDLC0JUsSo2iDXiXdiBvR nMdAsS+kjGgotWEPYJ54msys/afUX3LM736jlGPXvrjLrsdYvObXq1W3KCavxVH16qiFGm5CP trGclsjndIX+0dv9yN8uW4IDK4zTvqCdj6iNrKkZ29BhWjYISRDzwQ3vUhhEvb0lR78JwteIa 4lox8w/fvIVVvIx5Lj5tLgvJTMTypcXgLdrDC/Vqlo4X6kVRXrsT/dhM/qmHmMLy6aKIiyyMY pBSEYgw+1IUWHbsDfQ50BYGMQVlyQeao3I6OighaciwaIGGkIiD7ooeaE9ydh6TDpBNRQHBJ Received-SPF: pass client-ip=212.227.15.15; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283930 Archived-At: > I haven't tried your new patch yet ... don't ... > but I found pop-to-buffer-same-window > + switch-to-buffer-obey-display-actions ... these are two different pairs of shoes: 'switch-to-buffer-obey-display-actions' is meant for customizing the behavior of 'switch-to-buffer' - 'pop-to-buffer-same-window' should not be affected by it ... > inadequate for the sort of > behaviour required here, I had something like this (with the variable > set to t) > > (defadvice pop-to-buffer-same-window > (around reuse-existing-frame-advise > (buffer-or-name &optional norecord) activate) > (if current-prefix-arg > ad-do-it > (pop-to-buffer buffer-or-name > '((display-buffer-reuse-window > display-buffer-same-window) > . ((reusable-frames . 0) > (inhibit-same-window . nil))) > norecord))) > > This would *for the most part* obey the customizations via pop-up-frames > and pop-up-windows or via display-buffer-alist ... IIUC this is more or less what I suggested just that I left 'reusable-frames' alone ... > (as the manual now > suggests. the latter is not easy to customize 'graphic-only, and fails > in many ways with packages like consult and transient) Do you mean that we cannot separate the graphic and non-graphic cases via 'display-buffer-alist'? Too bad. One problem is that 'display-buffer-pop-up-frame' has to get through as 'display-buffer-fallback-action' when everything else failed before - even on a TTY. So a new action alist entry like 'inhibit-pop-up-frame' is needed - if t never pop up a new frame and if 'graphic-only pop up a new frame on a graphic terminal only. And ignore this entry in the fallback case. WDYT? martin