unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Madhu <enometh@meer.net>, emacs-devel@gnu.org
Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action'
Date: Sun, 2 Jan 2022 18:09:15 +0100	[thread overview]
Message-ID: <4b1c3a53-eb09-329f-9348-51d321b2893d@gmx.at> (raw)
In-Reply-To: <m3lezy9khk.fsf@leonis4.robolove.meer.net>

 > I haven't tried your new patch yet

... don't ...

 > but I found pop-to-buffer-same-window
 > + switch-to-buffer-obey-display-actions

... these are two different pairs of shoes:
'switch-to-buffer-obey-display-actions' is meant for customizing the
behavior of 'switch-to-buffer' - 'pop-to-buffer-same-window' should not
be affected by it ...

 > inadequate for the sort of
 > behaviour required here, I had something like this (with the variable
 > set to t)
 >
 > (defadvice pop-to-buffer-same-window
 >      (around reuse-existing-frame-advise
 > 	    (buffer-or-name &optional norecord) activate)
 >    (if current-prefix-arg
 >        ad-do-it
 >    (pop-to-buffer buffer-or-name
 > 		 '((display-buffer-reuse-window
 > 		    display-buffer-same-window)
 > 		   . ((reusable-frames . 0)
 > 		      (inhibit-same-window . nil)))
 > 		 norecord)))
 >
 > This would *for the most part* obey the customizations via pop-up-frames
 > and pop-up-windows or via display-buffer-alist

... IIUC this is more or less what I suggested just that I left
'reusable-frames' alone ...

 > (as the manual now
 > suggests. the latter is not easy to customize 'graphic-only, and fails
 > in many ways with packages like consult and transient)

Do you mean that we cannot separate the graphic and non-graphic cases
via 'display-buffer-alist'?  Too bad.

One problem is that 'display-buffer-pop-up-frame' has to get through as
'display-buffer-fallback-action' when everything else failed before -
even on a TTY.  So a new action alist entry like 'inhibit-pop-up-frame'
is needed - if t never pop up a new frame and if 'graphic-only pop up a
new frame on a graphic terminal only.  And ignore this entry in the
fallback case.  WDYT?

martin



  reply	other threads:[~2022-01-02 17:09 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org>
     [not found] ` <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org>
2021-12-28 22:37   ` master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Dmitry Gutov
2021-12-28 22:59     ` jakanakaevangeli
2021-12-29  8:17     ` Juri Linkov
2021-12-29 15:00   ` Lars Ingebrigtsen
2021-12-29 16:57     ` Eli Zaretskii
2021-12-30  8:34       ` martin rudalics
2021-12-30  8:47         ` martin rudalics
2021-12-30 10:25           ` martin rudalics
2021-12-30 14:40             ` Stefan Monnier
2021-12-30 17:12               ` martin rudalics
2021-12-30 17:29                 ` Lars Ingebrigtsen
2021-12-30 18:30                   ` martin rudalics
2021-12-31 16:29                     ` Lars Ingebrigtsen
2021-12-31 18:41                       ` martin rudalics
2021-12-30 16:04             ` Juri Linkov
2021-12-30 17:14               ` martin rudalics
2021-12-31 16:47                 ` Sam Steingold
2021-12-31 18:42                   ` martin rudalics
2021-12-31 16:38             ` Sam Steingold
2021-12-31 18:42               ` martin rudalics
2021-12-31 18:55                 ` Sam Steingold
2021-12-31 19:40                   ` martin rudalics
2022-01-03 17:22                     ` Sam Steingold
2021-12-30 17:24           ` Dmitry Gutov
2021-12-30 18:30             ` martin rudalics
2021-12-31 16:28               ` Lars Ingebrigtsen
2021-12-31 18:41                 ` martin rudalics
2022-01-02 16:21                   ` Madhu
2022-01-02 17:09                     ` martin rudalics [this message]
2022-01-02 17:43                   ` Juri Linkov
2022-01-02 18:40                     ` martin rudalics
2022-01-02 20:52                       ` Dmitry Gutov
2022-01-03  7:45                         ` Juri Linkov
2022-01-03 18:21                           ` martin rudalics
2022-01-03 18:38                             ` Stefan Monnier
2022-01-04 10:25                               ` martin rudalics
2022-01-04 15:48                                 ` Stefan Monnier
2022-01-03 21:07                             ` Juri Linkov
2022-01-04 10:26                               ` martin rudalics
2022-01-06 15:30                                 ` martin rudalics
2022-01-06 19:52                                   ` Juri Linkov
2022-01-07 10:36                                     ` martin rudalics
2022-01-07 18:49                                       ` Sam Steingold
2022-01-07 19:03                                         ` Eli Zaretskii
2022-01-07 19:16                                           ` Sam Steingold
2022-01-11 17:20                                       ` Juri Linkov
2022-01-11 18:02                                         ` martin rudalics
2022-01-11 18:15                                           ` Juri Linkov
2022-01-12  8:43                                             ` martin rudalics
2022-01-03  7:51                       ` Juri Linkov
2021-12-29 17:29     ` Sam Steingold
2021-12-29 16:43   ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b1c3a53-eb09-329f-9348-51d321b2893d@gmx.at \
    --to=rudalics@gmx.at \
    --cc=emacs-devel@gnu.org \
    --cc=enometh@meer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).