From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: ptrdiff_t misuse Date: Fri, 06 Jul 2012 07:51:10 -0700 Organization: UCLA Computer Science Department Message-ID: <4FF6FB5E.6090904@cs.ucla.edu> References: <83lij66yq9.fsf@gnu.org> <4FEDB953.1010800@yandex.ru> <4FEEA720.2040405@cs.ucla.edu> <4FEEFBAB.6000404@cs.ucla.edu> <4FF3E1D6.1050103@cs.ucla.edu> <83bojv4h13.fsf@gnu.org> <4FF48920.501@cs.ucla.edu> <83vci22mr0.fsf@gnu.org> <83obnu2e8s.fsf@gnu.org> <4FF62C92.8090406@cs.ucla.edu> <83liix2xvp.fsf@gnu.org> <4FF69476.2070701@cs.ucla.edu> <83k3yh2spu.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1341586289 10466 80.91.229.3 (6 Jul 2012 14:51:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Jul 2012 14:51:29 +0000 (UTC) Cc: dmantipov@yandex.ru, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 06 16:51:27 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sn9sT-0001dB-D0 for ged-emacs-devel@m.gmane.org; Fri, 06 Jul 2012 16:51:25 +0200 Original-Received: from localhost ([::1]:51604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn9sS-0007wd-FZ for ged-emacs-devel@m.gmane.org; Fri, 06 Jul 2012 10:51:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn9sM-0007wK-Sr for emacs-devel@gnu.org; Fri, 06 Jul 2012 10:51:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn9sL-000099-CW for emacs-devel@gnu.org; Fri, 06 Jul 2012 10:51:18 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:55125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn9sI-00007y-Lk; Fri, 06 Jul 2012 10:51:14 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 07BB0A6001D; Fri, 6 Jul 2012 07:51:11 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BkyqArS0yJeI; Fri, 6 Jul 2012 07:51:10 -0700 (PDT) Original-Received: from [192.168.1.4] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 8ED9BA60001; Fri, 6 Jul 2012 07:51:10 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 In-Reply-To: <83k3yh2spu.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151453 Archived-At: On 07/06/2012 01:34 AM, Eli Zaretskii wrote: >> If we change hscroll to EMACS_INT, we should also increase the max >> > hscroll value to MOST_POSITIVE_FIXNUM. > It's already that: > > ptrdiff_t hscroll_max = min (MOST_POSITIVE_FIXNUM, PTRDIFF_MAX); > ptrdiff_t new_hscroll = clip_to_bounds (0, hscroll, hscroll_max); > > (Of course, if we declare these variables EMACS_INT, PTRDIFF_MAX will > not be needed anymore.) > > Or did you mean something else? No, that's pretty much what I meant -- get rid of the PTRDIFF_MAX there while we're changing ptrdiff_t to EMACS_INT for hscroll values. Some other minor things would need changing too, but it shouldn't be a problem.