From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: ptrdiff_t misuse [was :Re: (empty)] Date: Fri, 06 Jul 2012 00:32:06 -0700 Organization: UCLA Computer Science Department Message-ID: <4FF69476.2070701@cs.ucla.edu> References: <83lij66yq9.fsf@gnu.org> <4FEDB953.1010800@yandex.ru> <4FEEA720.2040405@cs.ucla.edu> <4FEEFBAB.6000404@cs.ucla.edu> <4FF3E1D6.1050103@cs.ucla.edu> <83bojv4h13.fsf@gnu.org> <4FF48920.501@cs.ucla.edu> <83vci22mr0.fsf@gnu.org> <83obnu2e8s.fsf@gnu.org> <4FF62C92.8090406@cs.ucla.edu> <83liix2xvp.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1341559947 9999 80.91.229.3 (6 Jul 2012 07:32:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Jul 2012 07:32:27 +0000 (UTC) Cc: dmantipov@yandex.ru, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 06 09:32:26 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sn31a-0001zj-9a for ged-emacs-devel@m.gmane.org; Fri, 06 Jul 2012 09:32:22 +0200 Original-Received: from localhost ([::1]:55822 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn31Z-0001E7-8L for ged-emacs-devel@m.gmane.org; Fri, 06 Jul 2012 03:32:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn31U-00012O-Dr for emacs-devel@gnu.org; Fri, 06 Jul 2012 03:32:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn31O-0002n0-BB for emacs-devel@gnu.org; Fri, 06 Jul 2012 03:32:15 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:41827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn31L-0002mM-Ms; Fri, 06 Jul 2012 03:32:07 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 0808FA6000F; Fri, 6 Jul 2012 00:32:04 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tMEpAid0NCuJ; Fri, 6 Jul 2012 00:32:03 -0700 (PDT) Original-Received: from [192.168.1.4] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 359C4A60001; Fri, 6 Jul 2012 00:32:03 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 In-Reply-To: <83liix2xvp.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151445 Archived-At: On 07/05/2012 11:43 PM, Eli Zaretskii wrote: > The value of 'hscroll' comes from Lisp, > so it's in the range of an EMACS_INT. > Why not treat it as such? > > For that matter, why not change 'hscroll' in 'struct window' to > EMACS_INT as well? I would prefer that, yes. Although Stefan said last week that hscroll should be 'int' on the grounds that hscroll values greater than INT_MAX don't work anyway, perhaps that's moot now that you've fixed those problems with large hscroll values. If we change hscroll to EMACS_INT, we should also increase the max hscroll value to MOST_POSITIVE_FIXNUM.