From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: 'struct window' cleanup #3 Date: Wed, 27 Jun 2012 21:59:58 +0400 Message-ID: <4FEB4A1E.5060203@yandex.ru> References: <4FE827B6.6020306@yandex.ru> <4FE89369.2000708@gmx.at> <4FE896A9.3090002@yandex.ru> <4FE9643C.1090201@gmx.at> <83a9zq9jhp.fsf@gnu.org> <83lij98nhj.fsf@gnu.org> <4FEAB1EA.3000307@yandex.ru> <83ehp08y8f.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050000090100030500080004" X-Trace: dough.gmane.org 1340820022 21390 80.91.229.3 (27 Jun 2012 18:00:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 27 Jun 2012 18:00:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 27 20:00:20 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SjwXK-0003Sb-73 for ged-emacs-devel@m.gmane.org; Wed, 27 Jun 2012 20:00:18 +0200 Original-Received: from localhost ([::1]:42468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjwXK-0004ZI-96 for ged-emacs-devel@m.gmane.org; Wed, 27 Jun 2012 14:00:18 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjwXD-0004Yw-1A for emacs-devel@gnu.org; Wed, 27 Jun 2012 14:00:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SjwXB-0007PS-2o for emacs-devel@gnu.org; Wed, 27 Jun 2012 14:00:10 -0400 Original-Received: from forward1h.mail.yandex.net ([84.201.187.146]:45528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjwX4-0007BP-F5; Wed, 27 Jun 2012 14:00:02 -0400 Original-Received: from smtp2h.mail.yandex.net (smtp2h.mail.yandex.net [84.201.187.145]) by forward1h.mail.yandex.net (Yandex) with ESMTP id ED7159E29E8; Wed, 27 Jun 2012 21:59:59 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1340820000; bh=TquvFegCcVLhsj2UY5B8xaQpThnHyrCRgkzySn0roBY=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type; b=O3SDrO6RZ3NLqIVeAGWeVc+y06khD85JSVhGRhhQ6U29znPZzgUud0bngK9lP1z2S YJV2g19LRoW7F9z46jnrD4zU0RfPnUi7tdWUFIBlfoUTUmsL7Uyt2tmNrltZdQ4mHb lhgPX+9klOHa7fAF/d6h/O1kx5yB23Ueo9E9ENYk= Original-Received: from smtp2h.mail.yandex.net (localhost [127.0.0.1]) by smtp2h.mail.yandex.net (Yandex) with ESMTP id BB74117001D2; Wed, 27 Jun 2012 21:59:59 +0400 (MSK) Original-Received: from 213-148-21-55.gelicon.ru (213-148-21-55.gelicon.ru [213.148.21.55]) by smtp2h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id xwKiaY0t-xxK8gHhL; Wed, 27 Jun 2012 21:59:59 +0400 X-Yandex-Rcpt-Suid: eliz@gnu.org X-Yandex-Rcpt-Suid: emacs-devel@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1340819999; bh=TquvFegCcVLhsj2UY5B8xaQpThnHyrCRgkzySn0roBY=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type; b=TDOkPcQBgmmG8b0RGBiP7VsiRElzXJaPewVE6wB6aK9eR1IpO6kRhxSBcCfPurkVd mr+9h/GKMuOTtTIjv/PQdMaCi8QzI635UehlYBbLaqGq96jDEFxLRB7L5/p14q7/xN nVaokfbHfqV2uiFU3E+Csl0pwqD6Wer6dKcS9RUs= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 In-Reply-To: <83ehp08y8f.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 84.201.187.146 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151233 Archived-At: This is a multi-part message in MIME format. --------------050000090100030500080004 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/27/2012 09:24 PM, Eli Zaretskii wrote: >> Date: Wed, 27 Jun 2012 11:10:34 +0400 >> From: Dmitry Antipov >> CC: emacs-devel@gnu.org >> >> 1. IIUC, `window_initialized' is redundant and obsolete. > > Does it still work to run "./temacs -Q", after this change: > >> - if (window_initialized) >> + if (initialized) > > The reason I ask is because window_initialized was set non-zero in > init_window_once, which was called from emacs.c when 'initialized' is > zero. So the above 'if' would trigger when 'initialized' was zero, > but after your change it will only trigger when 'initialized' is > non-zero. Am I missing something? 'initialized' is zero when running > un-dumped Emacs, e.g. 'temacs'. I would like to propose alternate redesign for this: init_window_once sets Vframe_list to Qnil. After calling make_initial_frame, Vframe_list becomes non-nil, so !NILP (Vframe_list) means init_window_once was passed. Dmitry --------------050000090100030500080004 Content-Type: text/plain; charset=UTF-8; name="window_init.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="window_init.patch" PT09IG1vZGlmaWVkIGZpbGUgJ3NyYy9mcmFtZS5jJwotLS0gc3JjL2ZyYW1lLmMJMjAxMi0w Ni0yNiAxNDo0MTowMSArMDAwMAorKysgc3JjL2ZyYW1lLmMJMjAxMi0wNi0yNyAxNzo1NToy NyArMDAwMApAQCAtNDY1LDEwICs0NjUsNyBAQAogICBMaXNwX09iamVjdCBmcmFtZTsKIAog ICBlYXNzZXJ0IChpbml0aWFsX2tib2FyZCk7Ci0KLSAgLyogVGhlIGZpcnN0IGNhbGwgbXVz dCBpbml0aWFsaXplIFZmcmFtZV9saXN0LiAgKi8KLSAgaWYgKCEgKE5JTFAgKFZmcmFtZV9s aXN0KSB8fCBDT05TUCAoVmZyYW1lX2xpc3QpKSkKLSAgICBWZnJhbWVfbGlzdCA9IFFuaWw7 CisgIGVhc3NlcnQgKE5JTFAgKFZmcmFtZV9saXN0KSk7CiAKICAgdGVybWluYWwgPSBpbml0 X2luaXRpYWxfdGVybWluYWwgKCk7CiAKCj09PSBtb2RpZmllZCBmaWxlICdzcmMvd2luZG93 LmMnCi0tLSBzcmMvd2luZG93LmMJMjAxMi0wNi0yNiAxNDo0MTowMSArMDAwMAorKysgc3Jj L3dpbmRvdy5jCTIwMTItMDYtMjcgMTc6NTM6MDIgKzAwMDAKQEAgLTExNyw5ICsxMTcsNiBA QAogLyogSW5jcmVtZW50ZWQgZm9yIGVhY2ggd2luZG93IGNyZWF0ZWQuICAqLwogc3RhdGlj IGludCBzZXF1ZW5jZV9udW1iZXI7CiAKLS8qIE5vbnplcm8gYWZ0ZXIgaW5pdF93aW5kb3df b25jZSBoYXMgZmluaXNoZWQuICAqLwotc3RhdGljIGludCB3aW5kb3dfaW5pdGlhbGl6ZWQ7 Ci0KIC8qIEhvb2sgdG8gcnVuIHdoZW4gd2luZG93IGNvbmZpZyBjaGFuZ2VzLiAgKi8KIHN0 YXRpYyBMaXNwX09iamVjdCBRd2luZG93X2NvbmZpZ3VyYXRpb25fY2hhbmdlX2hvb2s7CiAK QEAgLTMwMTksOSArMzAxNiw3IEBACiAgIHdpbmRvd3Nfb3JfYnVmZmVyc19jaGFuZ2VkKys7 CiAKICAgLyogV2UgbXVzdCBzZWxlY3QgQlVGRkVSIGZvciBydW5uaW5nIHRoZSB3aW5kb3ct c2Nyb2xsLWZ1bmN0aW9ucy4gICovCi0gIC8qIFdlIGNhbid0IGNoZWNrICEgTklMUCAoVndp bmRvd19zY3JvbGxfZnVuY3Rpb25zKSBoZXJlCi0gICAgIGJlY2F1c2UgdGhhdCBtaWdodCBp dHNlbGYgYmUgYSBsb2NhbCB2YXJpYWJsZS4gICovCi0gIGlmICh3aW5kb3dfaW5pdGlhbGl6 ZWQpCisgIGlmICghTklMUCAoVmZyYW1lX2xpc3QpKQogICAgIHsKICAgICAgIHJlY29yZF91 bndpbmRfcHJvdGVjdCAoRnNldF9idWZmZXIsIEZjdXJyZW50X2J1ZmZlciAoKSk7CiAgICAg ICBGc2V0X2J1ZmZlciAoYnVmZmVyKTsKQEAgLTY0NzIsMTQgKzY0NjcsMTUgQEAKIHZvaWQK IGluaXRfd2luZG93X29uY2UgKHZvaWQpCiB7Ci0gIHN0cnVjdCBmcmFtZSAqZiA9IG1ha2Vf aW5pdGlhbF9mcmFtZSAoKTsKKyAgc3RydWN0IGZyYW1lICpmOworCisgIFZmcmFtZV9saXN0 ID0gUW5pbDsKKyAgZiA9IG1ha2VfaW5pdGlhbF9mcmFtZSAoKTsKICAgWFNFVEZSQU1FIChz ZWxlY3RlZF9mcmFtZSwgZik7CiAgIFZ0ZXJtaW5hbF9mcmFtZSA9IHNlbGVjdGVkX2ZyYW1l OwogICBtaW5pYnVmX3dpbmRvdyA9IGYtPm1pbmlidWZmZXJfd2luZG93OwogICBzZWxlY3Rl ZF93aW5kb3cgPSBmLT5zZWxlY3RlZF93aW5kb3c7CiAgIGxhc3Rfbm9ubWluaWJ1Zl9mcmFt ZSA9IGY7Ci0KLSAgd2luZG93X2luaXRpYWxpemVkID0gMTsKIH0KIAogdm9pZAoK --------------050000090100030500080004--