From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Davis Herring Newsgroups: gmane.emacs.devel Subject: Re: Proposal: 'struct window' cleanup Date: Mon, 21 May 2012 08:37:42 -0600 Organization: XCP-1 Message-ID: <4FBA5336.8090603@lanl.gov> References: <4FBA5060.7070702@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1337611086 9906 80.91.229.3 (21 May 2012 14:38:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 21 May 2012 14:38:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 21 16:38:03 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SWTkG-0000aH-1A for ged-emacs-devel@m.gmane.org; Mon, 21 May 2012 16:38:00 +0200 Original-Received: from localhost ([::1]:32780 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWTkF-0002BG-Io for ged-emacs-devel@m.gmane.org; Mon, 21 May 2012 10:37:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWTk9-00028I-S2 for emacs-devel@gnu.org; Mon, 21 May 2012 10:37:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWTk3-0004oC-Hz for emacs-devel@gnu.org; Mon, 21 May 2012 10:37:53 -0400 Original-Received: from proofpoint4.lanl.gov ([204.121.3.52]:51941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWTk3-0004nO-63 for emacs-devel@gnu.org; Mon, 21 May 2012 10:37:47 -0400 Original-Received: from mailrelay1.lanl.gov (mailrelay1.lanl.gov [128.165.4.101]) by proofpoint4.lanl.gov (8.14.4/8.14.4) with ESMTP id q4LEbhAi012641; Mon, 21 May 2012 08:37:43 -0600 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by mailrelay1.lanl.gov (Postfix) with ESMTP id 07DB9E205B2; Mon, 21 May 2012 08:37:43 -0600 (MDT) X-NIE-2-Virus-Scanner: amavisd-new at mailrelay1.lanl.gov Original-Received: from [128.165.123.187] (xray-r07.lanl.gov [128.165.123.187]) by mailrelay1.lanl.gov (Postfix) with ESMTP id E85B4E205AC; Mon, 21 May 2012 08:37:42 -0600 (MDT) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110717 Lanikai/3.1.11 In-Reply-To: <4FBA5060.7070702@yandex.ru> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.6.7580, 1.0.260, 0.0.0000 definitions=2012-05-21_02:2012-05-21, 2012-05-21, 1970-01-01 signatures=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 204.121.3.52 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:150578 Archived-At: > @@ -3097,14 +3096,14 @@ > { > if (!EQ (tem, buffer)) > { > - if (EQ (w->dedicated, Qt)) > + if (w->dedicated_p) > /* WINDOW is strongly dedicated to its buffer, signal an > error. */ > error ("Window is dedicated to `%s'", SDATA (BVAR (XBUFFER (tem), name))); > else > /* WINDOW is weakly dedicated to its buffer, reset > dedication. */ > - w->dedicated = Qnil; > + w->dedicated_p = 0; > > call1 (Qrecord_window_buffer, window); w->dedicated is not merely a boolean, as seen here; it can be set other than to t. > @@ -206,11 +191,6 @@ > no scroll bar. A value of t means use frame value. */ > Lisp_Object vertical_scroll_bar_type; > > - /* Frame coords of mark as of last time display completed */ > - /* May be nil if mark does not exist or was not on frame */ > - Lisp_Object last_mark_x; > - Lisp_Object last_mark_y; > - > /* Z - the buffer position of the last glyph in the current matrix > of W. Only valid if WINDOW_END_VALID is not nil. */ > Lisp_Object window_end_pos; I guess these weren't used at all? They were never booleans. Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.