From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Matching regex case-sensitively in C strings? Date: Wed, 9 Nov 2022 11:33:09 +0100 Message-ID: <4FB7E922-5E36-4E0C-9681-9EC0E719CC8D@acm.org> References: <218795BA-107D-4A86-9ACF-0A44BD2EC3D2@gmail.com> <83edufyoad.fsf@gnu.org> <580E87E6-DCFD-42AE-807A-339BBB3878C2@acm.org> <5711A9D3-7BCB-44AE-8911-5E039FF5FBB8@gmail.com> <838rklxmnm.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23759"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 09 11:34:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osiPl-0005xj-HQ for ged-emacs-devel@m.gmane-mx.org; Wed, 09 Nov 2022 11:34:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osiOt-0006jw-CE; Wed, 09 Nov 2022 05:33:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osiOq-0006iR-AD for emacs-devel@gnu.org; Wed, 09 Nov 2022 05:33:40 -0500 Original-Received: from mail213c50.megamailservers.eu ([91.136.10.223] helo=mail194c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osiOo-000828-1W; Wed, 09 Nov 2022 05:33:40 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1667989998; bh=vZaxsl9rHuHzZPjlT4Zk1Vnv4q0pLAHIl1gi69lXHz8=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=mHmjFHR/8kklQMfjBSxTfkIW9ZUyCkEp97WXW9kKy19kRZwBm8UK3d0OirJBd6lmH t8TMnqgBbtflml9TxemQkQ/CUvQcOhILFAIuEgUm4EVGbA+2CASXKuajwhWV43lWdZ bMGystj7MprFQUlP7wgXixlJjV2RYNzNZxoVYF14= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se [188.150.171.209]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 2A9AXAD2046027; Wed, 9 Nov 2022 10:33:15 +0000 In-Reply-To: <838rklxmnm.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A782F16.636B81ED.0021, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.10.223; envelope-from=mattiase@acm.org; helo=mail194c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299396 Archived-At: 8 nov. 2022 kl. 20.37 skrev Eli Zaretskii : > Please don't call this "translate_table", as it isn't. The > documentation elsewhere calls this "canonicalize_table" or just > "canonicalize". Agreed. >> fast_c_string_match_ignore_case (Lisp_Object regexp, >> const char *string, ptrdiff_t len) >> { >> + return fast_c_string_match (regexp, string, len, true); >> +} >=20 > I'm bothered that this function, which is supposed to be fast, will > now be slower due to an extra function call. You are right to worry about it, but there is actually no need for = concern here: it's a tail call (and the extra argument is last) so it = should compile to an unconditional jump (and setting a register). You = would be hard-pressed to measure the "cost" even if you looked at cycle = counters.