From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Windows 64 port Date: Tue, 27 Mar 2012 09:08:08 -0700 Organization: UCLA Computer Science Department Message-ID: <4F71E5E8.1010306@cs.ucla.edu> References: <20120219211800.0000558f@unknown> <834numv7js.fsf@gnu.org> <83ty2ltep0.fsf@gnu.org> <4F4EEBC2.5070704@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1332864523 13202 80.91.229.3 (27 Mar 2012 16:08:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 27 Mar 2012 16:08:43 +0000 (UTC) Cc: Eli Zaretskii , ajmr@ilovetortilladepatatas.com, emacs-devel@gnu.org To: Fabrice Popineau Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 27 18:08:42 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SCYwq-0004BH-2v for ged-emacs-devel@m.gmane.org; Tue, 27 Mar 2012 18:08:40 +0200 Original-Received: from localhost ([::1]:42844 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCYwp-0002z1-46 for ged-emacs-devel@m.gmane.org; Tue, 27 Mar 2012 12:08:39 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCYwj-0002xO-3d for emacs-devel@gnu.org; Tue, 27 Mar 2012 12:08:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCYwc-0002IX-UI for emacs-devel@gnu.org; Tue, 27 Mar 2012 12:08:32 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:51309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCYwU-0002F3-P4; Tue, 27 Mar 2012 12:08:18 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 359C9A60002; Tue, 27 Mar 2012 09:08:09 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vq7Ao30zsqRE; Tue, 27 Mar 2012 09:08:08 -0700 (PDT) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 82603A60001; Tue, 27 Mar 2012 09:08:08 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120310 Thunderbird/11.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:149228 Archived-At: On 03/27/2012 05:47 AM, Fabrice Popineau wrote: > 2012/3/1 Paul Eggert > > > > - unsigned long int magic; /* Magic number to check header integrity. */ > > + uint64_t magic; /* Magic number to check header integrity. */ > > Not needed for Windows 64, since the magic number fits in 32 bits. > > If it fits in 32 bits, then it shouldn't be long in first place? Yes, it'd be reasonable to change this. However, any such change is independent of the Windows 64 port (as it would be just as reasonable to change it to 'unsigned int' for x86-64 GNU/Linux too), and so it should be considered as a separate patch.