From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Call for volunteers: add tree-sitter support to major modes Date: Tue, 11 Oct 2022 01:51:29 -0700 Message-ID: <4F573682-D9F6-466E-916C-BEFB67DEBB09@gmail.com> References: <83czb1jrm3.fsf@gnu.org> <878rlo7on0.fsf@thornhill.no> <83o7uki5ol.fsf@gnu.org> <87tu4c5g9j.fsf@thornhill.no> <87k057j7gn.fsf@yahoo.com> <8D3026E9-D8A4-46EC-816B-1F7A3458DC02@gmail.com> <83h70ag7dh.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2646"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , Theodor Thornhill , Alan Mackenzie , emacs-devel , jostein@kjonigsen.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 11 11:16:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiBN1-0000VL-BF for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 11:16:15 +0200 Original-Received: from localhost ([::1]:43732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiBMz-0000u5-Ro for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 05:16:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiAzC-0005OO-AK for emacs-devel@gnu.org; Tue, 11 Oct 2022 04:51:38 -0400 Original-Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:45983) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiAz8-0001Ts-Vn; Tue, 11 Oct 2022 04:51:37 -0400 Original-Received: by mail-pf1-x42f.google.com with SMTP id 67so12894736pfz.12; Tue, 11 Oct 2022 01:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=16U0DI0RkrBHTFMaoeOBlrVvUrKm4m5dGK2UZSvLSIo=; b=Jjci0Q5BseTq1r5dtEwWYL2fkeK/9/mBkb2+LzjUHiZtC8UPzo/4tM6zbvhB5XF/JH idVoCOqQCLHdWftL6fv0fzL4hsYZYVhsX+xMzHe2jK13s1/R25hFZraZ3nSA1qNV0xM8 Ph01d6Y6VejH3iPg9urIZHcHFm+wA+kuBk9z9SLgc3g6CitkOiPWPEEh0n/PMCCH+Z+5 0Awx1aJgWb5AfYGl72Z1LBvh/HK8uKe6i4XyWtw5Fu+RYPtOn3QEOsRqvtNKkpBjhUuj zHMibCl7h4aKJW+qdl4zoVsJkappV+XgHb3K87VU8CtA8VRe01c62ihzcy707O/ixvbq cqMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=16U0DI0RkrBHTFMaoeOBlrVvUrKm4m5dGK2UZSvLSIo=; b=c9Bbfc1M3dzV3krDFjGO6mLsTO7LOBNuLK/GD9DYVXF+qMGdOdeknS7rjYD/5ET3sL 7JwTiR5GY7eMUAedondJxzOf/cEbahvuB7oXSzS+VAcvu2Btt4pFLphFQkE94zBcznPE j+K98Dd//RdtKCj/vrBvhNBY1LVV5beogvoPiM4wBCP4R8x1tSWc8BEB/CvEmJf3G9AA 8/oPrSwIHE0YrJ3s29TXMHJzdlk/PkfHUaSoqkE20d1a7IXf+9MYqz/wVj0ap02EliKp 6XZlHEF+XNp92VaB8JsfSkj5mxXwP4HHzgYElOH9zsvU/Js06eh+ETQoOGs2f8teE9Mn txnA== X-Gm-Message-State: ACrzQf30IIQh9LynweOviJZwlEhhGIO0mCg79ybeyNJRbpM2Re/nMCoi hXD6m6bmy60VNJXwaDEaVokFsD+cQq4QSg== X-Google-Smtp-Source: AMsMyM6iyCBHJ6PeA04efRhx+cDGKnR1UxVJ6U1DrjH3YxzU1sjFl2qHnnWUC/imFhnSa5j5Z+UYDQ== X-Received: by 2002:a63:8149:0:b0:461:f9f7:f64a with SMTP id t70-20020a638149000000b00461f9f7f64amr9163003pgd.338.1665478292169; Tue, 11 Oct 2022 01:51:32 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 77-20020a621450000000b0056281da3bcbsm8630317pfu.149.2022.10.11.01.51.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Oct 2022 01:51:31 -0700 (PDT) In-Reply-To: <83h70ag7dh.fsf@gnu.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=casouri@gmail.com; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297462 Archived-At: > On Oct 11, 2022, at 12:13 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Mon, 10 Oct 2022 22:14:36 -0700 >> Cc: Theodor Thornhill , >> Eli Zaretskii , >> Alan Mackenzie , >> emacs-devel , >> jostein@kjonigsen.net >>=20 >> Tree-sitter library and the =E2=80=9Cofficial=E2=80=9D language = definitions are all MIT licensed. So nothing prevents us from including = it copyright-wise. >=20 > I see no reason whatsoever to consider bundling tree-sitter. Building > it is very easy, and w=3Donce Emacs starts using it seriously, the = Emacs > distros will take care of offering suitable tree-sitter distributions. I agree, I was replying to Po=E2=80=99s explaining there is no copyright = issue. >=20 >>> My opinion is that Emacs should not degrade its text editing >>> capabilities so drastically if a non-system library (i.e. not = ncurses or >>> Xlib) is not present. >>=20 >> Considering that Emacs currently doesn=E2=80=99t have C# and = typescript support in core at all, I wouldn=E2=80=99t call it a = downgrade. But I agree the idea that a major mode requiring external = dependency to function is not very comfortable. >=20 > I don't agree, and don't feel myself uncomfortable at all. For the > same reason I don't feel uncomfortable because we use HarfBuzz for > rendering and GnuTLS for networking. Oh, I=E2=80=99m perfectly comfortable with having build dependency on = tree-sitter. I was not comfortable with having a built-in major mode = that simply errors out when tree-sitter is not available. But if we are = going to include some minimal support into typescript-mode in the case = where tree-sitter is unavailable, as you suggested in a message, then = I=E2=80=99m very comfortable ;-) Yuan=