From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Windows 64 port Date: Wed, 29 Feb 2012 14:08:37 -0800 Organization: UCLA Computer Science Department Message-ID: <4F4EA1E5.6000602@cs.ucla.edu> References: <20120219211800.0000558f@unknown> <834numv7js.fsf@gnu.org> <4F428780.8070902@cs.ucla.edu> <4F4D507F.7030008@cs.ucla.edu> <83mx81cy18.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1330553372 3276 80.91.229.3 (29 Feb 2012 22:09:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 29 Feb 2012 22:09:32 +0000 (UTC) Cc: Fabrice Popineau , emacs-devel@gnu.org, ajmr@ilovetortilladepatatas.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 29 23:09:31 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S2riE-0004iB-Rc for ged-emacs-devel@m.gmane.org; Wed, 29 Feb 2012 23:09:30 +0100 Original-Received: from localhost ([::1]:56510 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2riD-0005pT-W5 for ged-emacs-devel@m.gmane.org; Wed, 29 Feb 2012 17:09:29 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2riB-0005pM-3r for emacs-devel@gnu.org; Wed, 29 Feb 2012 17:09:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2rhq-0007c3-M6 for emacs-devel@gnu.org; Wed, 29 Feb 2012 17:09:26 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:36449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2rhS-0007Ke-P8; Wed, 29 Feb 2012 17:08:42 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id B292A39E8012; Wed, 29 Feb 2012 14:08:38 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h6o00OXb9Vat; Wed, 29 Feb 2012 14:08:38 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id DD7DF39E800C; Wed, 29 Feb 2012 14:08:37 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 In-Reply-To: <83mx81cy18.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148843 Archived-At: On 02/29/2012 10:08 AM, Eli Zaretskii wrote: > I agree that such confusing code, even if it does its job correctly, > is bad for maintainability. This particular code is fairly clear when you look at the code's context (and it's also clear that there's no bug that the patch would fix). Any patch that adds a comment should take that context into account. Also, since this code is imported from gnulib the patch should be sent to bug-gnulib.