From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Windows 64 port Date: Tue, 28 Feb 2012 14:09:03 -0800 Organization: UCLA Computer Science Department Message-ID: <4F4D507F.7030008@cs.ucla.edu> References: <20120219211800.0000558f@unknown> <834numv7js.fsf@gnu.org> <4F428780.8070902@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1330466960 25733 80.91.229.3 (28 Feb 2012 22:09:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 28 Feb 2012 22:09:20 +0000 (UTC) Cc: Eli Zaretskii , AJMR , emacs-devel@gnu.org To: Fabrice Popineau Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 28 23:09:18 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S2VET-00046O-35 for ged-emacs-devel@m.gmane.org; Tue, 28 Feb 2012 23:09:17 +0100 Original-Received: from localhost ([::1]:52771 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2VES-0000r5-Bq for ged-emacs-devel@m.gmane.org; Tue, 28 Feb 2012 17:09:16 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2VEP-0000qg-8z for emacs-devel@gnu.org; Tue, 28 Feb 2012 17:09:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2VEN-0001Lz-JM for emacs-devel@gnu.org; Tue, 28 Feb 2012 17:09:12 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:53258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2VEK-0001Ka-9E; Tue, 28 Feb 2012 17:09:08 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 5E9DF39E800C; Tue, 28 Feb 2012 14:09:04 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xJo9ZSQn9tyr; Tue, 28 Feb 2012 14:09:03 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id B509339E800B; Tue, 28 Feb 2012 14:09:03 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148831 Archived-At: On 02/28/2012 01:00 PM, Fabrice Popineau wrote: > int aligned = (ABLOCKS_BUSY(abase) != NULL); > > would have been cleaner. Perhaps, but it'd also be a bit slower, and at any rate this should be a separate patch, since the change is independent of the Windows 64 port. Any Windows 64 patch should be limited to issues that are actually needed for a Windows 64 port. > There is something wrong around lib/strftime.c:946 > if (negative_number) > u_number_value = - u_number_value; > > u_number_value being unsigned, this is wrong. I don't see anything wrong there. The value of -X is well-defined if X is unsigned int; it's equivalent to ~X + 1. Can you supply a test case illustrating the actual bug? Please bear in mind that the code is already tested to LP64 hosts. Any bug related to this particular code would also be a bug on LP64 hosts, no? So, it's not likely that any bug here is specific to Windows 64. If there is a bug, it should be describable and fixable independently of Windows 64. > In src/dispnew.c:6402, height and width should probably be unsigned. The > checking by > INT_ADD_RANGE_OVERFLOW results in a compiler warning about integral > constant overflow > because it tries to compute (INTMIN - 2) which obviously is out of range. > The value is not used in this case, but the compiler may emit the warning > anyway. We don't need to modify the mainline Emacs code in order to pacify third-party compilers that issue incorrect warnings. We can safely ignore these warnings and leave the code alone.