From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107377: * src/lisp.h: Improve comment about USE_LSB_TAG. Date: Sat, 25 Feb 2012 11:46:33 -0800 Organization: UCLA Computer Science Department Message-ID: <4F493A99.6070708@cs.ucla.edu> References: <4F459455.8070206@verizon.net> <4F45DD5B.3010801@cs.ucla.edu> <4F488717.2060108@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1330199211 24794 80.91.229.3 (25 Feb 2012 19:46:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 25 Feb 2012 19:46:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 25 20:46:51 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S1NZy-0007CC-6r for ged-emacs-devel@m.gmane.org; Sat, 25 Feb 2012 20:46:50 +0100 Original-Received: from localhost ([::1]:57183 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1NZx-0002iA-J4 for ged-emacs-devel@m.gmane.org; Sat, 25 Feb 2012 14:46:49 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1NZp-0002hq-36 for emacs-devel@gnu.org; Sat, 25 Feb 2012 14:46:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1NZi-00083e-55 for emacs-devel@gnu.org; Sat, 25 Feb 2012 14:46:40 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:45074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1NZh-00083Q-VF for emacs-devel@gnu.org; Sat, 25 Feb 2012 14:46:34 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id A2BB539E800E; Sat, 25 Feb 2012 11:46:32 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9QoJKWfsKr3D; Sat, 25 Feb 2012 11:46:32 -0800 (PST) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 51C8F39E800C; Sat, 25 Feb 2012 11:46:32 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148782 Archived-At: OK, thanks, I installed a patch along the lines you suggested into the trunk, as bzr 107429. The patch differs from your suggestion only in that it uses a different name for the local variable (to avoid shadowing warnings) and it uses the test (sizeof (void *) < sizeof (Lisp_Object)) rather than (defined WIDE_EMACS_INT) as this identifies the problem more accurately (the problem can occur even if WIDE_EMACS_INT is not defined).