From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Windows 64 port Date: Mon, 20 Feb 2012 09:48:48 -0800 Organization: UCLA Computer Science Department Message-ID: <4F428780.8070902@cs.ucla.edu> References: <20120219211800.0000558f@unknown> <834numv7js.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1329760135 19601 80.91.229.3 (20 Feb 2012 17:48:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 20 Feb 2012 17:48:55 +0000 (UTC) Cc: Eli Zaretskii , AJMR , emacs-devel@gnu.org To: Fabrice Popineau Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 20 18:48:52 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RzXM3-0003MU-Rt for ged-emacs-devel@m.gmane.org; Mon, 20 Feb 2012 18:48:52 +0100 Original-Received: from localhost ([::1]:54249 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzXM3-0004c9-G8 for ged-emacs-devel@m.gmane.org; Mon, 20 Feb 2012 12:48:51 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:60997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzXLw-0004VZ-95 for emacs-devel@gnu.org; Mon, 20 Feb 2012 12:48:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RzXLr-000346-U1 for emacs-devel@gnu.org; Mon, 20 Feb 2012 12:48:44 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:58137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzXLm-00031y-3F; Mon, 20 Feb 2012 12:48:34 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 5592939E8008; Mon, 20 Feb 2012 09:48:26 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kT+TjCToOb1V; Mon, 20 Feb 2012 09:48:26 -0800 (PST) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id DACEE39E8007; Mon, 20 Feb 2012 09:48:25 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148682 Archived-At: I took a quick look, found several problems, and thought I'd write one or two down before I forgot them.... The patch is too intrusive to the mainline code and many of its changes should be omitted. Generally speaking it's OK (for portability to future POSIX hosts) to replace 'long' with 'ptrdiff_t' or 'ssize_t' or 'intptr_t' when appropriate, and to replace 'unsigned long' with 'size_t' or 'uintptr_t' as appropriate, but other type replacements are dubious and should generally be omitted. For example: - int i = 0, aligned = (intptr_t) ABLOCKS_BUSY (abase); + int i = 0; + intptr_t aligned = (intptr_t) ABLOCKS_BUSY (abase); Here, the value of 'aligned' is either 0 or 1, so there's no need to change its type. The changes to src/m/amdx86-64.h would break GNU/Linux and need to be backed out and redone. This mishandles Emacs integers outside the signed 32-bit range: -#define XFASTINT(a) ((a) + 0) +#define XFASTINT(a) ((int)((a) + 0))