From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107264: shr.el (shr-rescale-image): Allow viewing large images. Date: Tue, 14 Feb 2012 07:56:28 -0800 Organization: UCLA Computer Science Department Message-ID: <4F3A842C.5020907@cs.ucla.edu> References: <874nuuwlib.fsf@gnus.org> <4F3972C3.2010209@cs.ucla.edu> <8762fawk1t.fsf@gnus.org> <4F3A194F.8000508@cs.ucla.edu> <87haytfp0u.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1329235028 14962 80.91.229.3 (14 Feb 2012 15:57:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 14 Feb 2012 15:57:08 +0000 (UTC) Cc: Katsumi Yamaoka , Stefan Monnier , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 14 16:57:03 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RxKkZ-0006EC-7b for ged-emacs-devel@m.gmane.org; Tue, 14 Feb 2012 16:57:03 +0100 Original-Received: from localhost ([::1]:47859 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxKkT-0004Sw-Jg for ged-emacs-devel@m.gmane.org; Tue, 14 Feb 2012 10:56:57 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:45329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxKkN-0004S6-Bo for emacs-devel@gnu.org; Tue, 14 Feb 2012 10:56:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxKkD-0006Bg-EF for emacs-devel@gnu.org; Tue, 14 Feb 2012 10:56:51 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:52606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxKkD-0006BT-4m for emacs-devel@gnu.org; Tue, 14 Feb 2012 10:56:41 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 2F34739E800B; Tue, 14 Feb 2012 07:56:37 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8Bmwkmsv3qYP; Tue, 14 Feb 2012 07:56:36 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id B491439E800A; Tue, 14 Feb 2012 07:56:36 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 In-Reply-To: <87haytfp0u.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148608 Archived-At: On 02/14/2012 06:49 AM, Lars Ingebrigtsen wrote: > I think the limit should be set to something that gives as little > problems to real-world usage as realistic. 6.0 is too small, nil is > unresponsible, and 60.0 is probably too large. 10.0? 10.0 would be fine, I think, not too large for older desktops with big displays. The current value of 6.0 was established in 2005, and the typical ratio of RAM to display size for older machines has probably grown by a factor of (10/6)**2 since then. But it should be 10.0 everywhere, no? Not just in Gnus. That is, shouldn't the change be something like this? === modified file 'lisp/gnus/shr.el' --- lisp/gnus/shr.el 2012-02-13 11:25:56 +0000 +++ lisp/gnus/shr.el 2012-02-14 15:54:44 +0000 @@ -557,8 +557,7 @@ (insert alt))) (defun shr-rescale-image (data) - (let* ((max-image-size nil) - (image (create-image data nil t :ascent 100))) + (let ((image (create-image data nil t :ascent 100))) (if (or (not (fboundp 'imagemagick-types)) (not (get-buffer-window (current-buffer)))) image === modified file 'src/image.c' --- src/image.c 2012-02-07 03:46:18 +0000 +++ src/image.c 2012-02-14 15:54:07 +0000 @@ -976,7 +976,7 @@ static void free_image (struct frame *f, struct image *img); -#define MAX_IMAGE_SIZE 6.0 +#define MAX_IMAGE_SIZE 10.0 /* Allocate and return a new image structure for image specification SPEC. SPEC has a hash value of HASH. */