unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Should (icomplete-mode) explicitly disable fido-mode?
@ 2020-06-04 17:49 Andrew Schwartzmeyer
  2020-06-05 22:48 ` João Távora
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Schwartzmeyer @ 2020-06-04 17:49 UTC (permalink / raw)
  To: emacs-devel; +Cc: João Távora

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

Hi João,

I was wondering if this bit of code in icomplete-mode needs to be changed:

  (when icomplete-mode
    (fido-mode -1)...

Running (icomplete-mode) explicitly disables fido-mode, whereas running (fido-mode) makes it appear that icomplete-mode is enabled (sets it to t and runs its setup, without actually running the function icomplete-mode).

This causes third party packages which wrap icomplete-mode to easily break fido-mode, like in this issue: https://github.com/oantolin/icomplete-vertical/pull/13 <https://github.com/oantolin/icomplete-vertical/pull/13>

icomplete-vertical calls (icomplete-mode), I think expecting it to be idempotent (not have any effect if icomplete-mode is already enabled), but in fact, since fido-mode is currently enabled this explicitly disables it and switches to the base icomplete-mode, as the mode functions icomplete-mode and fido-mode act like toggles of each other.

Should (icomplete-mode t) perhaps do nothing if fido-mode is already enabled? I’m not sure. Obviously the package can workaround it (given my patch), but I think it’s unexpected to have to avoid calling (icomplete-mode) if the icomplete-mode var is already t. What do you think?

Thanks,

Andy

[-- Attachment #2: Type: text/html, Size: 1921 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-06-06  5:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-04 17:49 Should (icomplete-mode) explicitly disable fido-mode? Andrew Schwartzmeyer
2020-06-05 22:48 ` João Távora
2020-06-05 23:19   ` Stefan Monnier
2020-06-06  5:14   ` Andrew Schwartzmeyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).