From: Daniel Colascione <dancol@dancol.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH 4/4] Fix emacsclient to work with cygw32
Date: Thu, 29 Dec 2011 08:36:38 -0800 [thread overview]
Message-ID: <4EFC9716.3050209@dancol.org> (raw)
In-Reply-To: <CAAeL0SSGx6h-Ne9_zVecHqLrBmwP=gmqF7PpjTXZ=_JNGrhcPw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]
On 12/29/11 8:28 AM, Juanma Barranquero wrote:
> On Thu, Dec 29, 2011 at 15:03, Daniel Colascione <dancol@dancol.org> wrote:
>
>> - ;; On Windows, emacsclient always asks for a tty frame.
>> - ;; If running a GUI server, force the frame type to GUI.
>> - (when (eq window-system 'w32)
>> + ;; On Windows, emacsclient always asks for a tty
>> + ;; frame. If running a GUI server, force the frame
>> + ;; type to GUI. (Cygwin is perfectly happy with
>> + ;; multi-tty support, so don't override the user's
>> + ;; choice there.)
>> + (when (and (eq system-type 'windows-nt)
>> + (eq window-system 'w32))
This hunk narrows the scope of a windows-nt special case so that it
doesn't apply to Cygwin.
> Don't you need to fix also this?
>
> ;; Delete the client's tty, except on Windows (both GUI and console),
> ;; where there's only one terminal and does not make sense to delete it.
> (unless (eq system-type 'windows-nt)
> (let ((terminal (process-get proc 'terminal)))
> ;; Only delete the terminal if it is non-nil.
> (when (and terminal (eq (terminal-live-p terminal) t))
> (delete-terminal terminal))))
>
> Juanma
>
No --- a Cygwin tty acts like a tty on any other unix, so we don't want
to treat it specially. The comment refers to native Windows consoles only.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 235 bytes --]
next prev parent reply other threads:[~2011-12-29 16:36 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 14:03 [PATCH 0/4] Support Win32 GUI in Cygwin Emacs Daniel Colascione
2011-12-29 14:03 ` [PATCH 3/4] Implement cygw32 Daniel Colascione
2011-12-29 17:29 ` Eli Zaretskii
2011-12-29 17:53 ` Daniel Colascione
2011-12-29 18:17 ` Eli Zaretskii
2011-12-29 21:50 ` Daniel Colascione
2011-12-30 0:56 ` Jason Rumney
2011-12-30 9:23 ` Eli Zaretskii
2011-12-30 9:36 ` Daniel Colascione
2011-12-30 11:16 ` Eli Zaretskii
2011-12-30 9:49 ` Andreas Schwab
2011-12-29 14:03 ` [PATCH 2/4] Refactor window-system configuration Daniel Colascione
2011-12-29 22:21 ` Dan Nicolaescu
2011-12-29 22:29 ` Daniel Colascione
2011-12-29 22:43 ` Dan Nicolaescu
2011-12-29 22:48 ` Daniel Colascione
2011-12-29 23:05 ` Dan Nicolaescu
2011-12-29 23:08 ` Daniel Colascione
2011-12-30 8:54 ` Eli Zaretskii
2011-12-30 9:07 ` Daniel Colascione
2011-12-30 9:44 ` Eli Zaretskii
2011-12-30 0:53 ` Stefan Monnier
2011-12-30 8:21 ` Eli Zaretskii
2011-12-30 8:26 ` Daniel Colascione
2011-12-30 9:38 ` Eli Zaretskii
2011-12-30 9:45 ` Daniel Colascione
2011-12-30 11:15 ` Stefan Monnier
2011-12-30 8:19 ` Eli Zaretskii
2011-12-29 14:03 ` [PATCH 1/4] Compilation cleanups Daniel Colascione
2011-12-29 17:54 ` Paul Eggert
2011-12-31 14:50 ` Ken Brown
2011-12-31 20:29 ` Paul Eggert
2011-12-29 14:03 ` [PATCH 4/4] Fix emacsclient to work with cygw32 Daniel Colascione
2011-12-29 16:28 ` Juanma Barranquero
2011-12-29 16:36 ` Daniel Colascione [this message]
2011-12-29 16:43 ` Juanma Barranquero
2011-12-29 16:47 ` Daniel Colascione
2011-12-29 16:49 ` Juanma Barranquero
2011-12-29 17:39 ` Eli Zaretskii
2011-12-29 17:56 ` Daniel Colascione
2011-12-29 18:18 ` Eli Zaretskii
2011-12-29 18:53 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFC9716.3050209@dancol.org \
--to=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).