From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] some misuse of GCPROs Date: Fri, 18 Nov 2011 21:24:45 +0400 Message-ID: <4EC694DD.4050908@yandex.ru> References: <4EC6667E.3040008@yandex.ru> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1321647356 16333 80.91.229.12 (18 Nov 2011 20:15:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2011 20:15:56 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 18 21:15:52 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RRUql-0004mN-QX for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2011 21:15:51 +0100 Original-Received: from localhost ([::1]:44621 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRUqk-0008VQ-Vw for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2011 15:15:50 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:37337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRSB1-0001br-8l for emacs-devel@gnu.org; Fri, 18 Nov 2011 12:24:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRSB0-00044Q-Ak for emacs-devel@gnu.org; Fri, 18 Nov 2011 12:24:35 -0500 Original-Received: from mail-bw0-f41.google.com ([209.85.214.41]:60856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRSB0-00044H-5W for emacs-devel@gnu.org; Fri, 18 Nov 2011 12:24:34 -0500 Original-Received: by bke17 with SMTP id 17so4431088bke.0 for ; Fri, 18 Nov 2011 09:24:32 -0800 (PST) Original-Received: by 10.204.156.208 with SMTP id y16mr4321735bkw.72.1321637071844; Fri, 18 Nov 2011 09:24:31 -0800 (PST) Original-Received: from [192.168.0.171] ([78.153.153.8]) by mx.google.com with ESMTPS id x14sm1263369bkf.10.2011.11.18.09.24.30 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 18 Nov 2011 09:24:31 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.214.41 X-Mailman-Approved-At: Fri, 18 Nov 2011 15:15:49 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146091 Archived-At: On 11/18/2011 08:51 PM, Stefan Monnier wrote: > I really dislike this inner_gcpro business, so I haven't installed > this hunk. What is it needed for? I too, but this is a fix for 'reuse GCPRO' error. The following code ... Lisp_Object foo; struct gcpro gcpro1; ... GCPRO1 (foo); ... if (...) { Lisp_Object bar; ... GCPRO1 (bar); ... UNGCPRO; } .... is wrong because it clears the protection of 'foo' by re-using 'gcpro1' to protect 'bar'. It should be: ... Lisp_Object foo; struct gcpro gcpro1; ... GCPRO1 (foo); ... if (...) { Lisp_Object bar; struct gcpro inner_gcpro1; ... GCPRO1_VAR (bar, inner_gcpro); ... UNGCPRO_VAR (inner_gcpro); } .... Dmitry