From: martin rudalics <rudalics@gmx.at>
To: Chong Yidong <cyd@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: window-resizable confusion
Date: Wed, 09 Nov 2011 10:45:06 +0100 [thread overview]
Message-ID: <4EBA4BA2.3030406@gmx.at> (raw)
In-Reply-To: <87hb2daj1c.fsf@gnu.org>
> I think the NOUP and NODOWN arguments should be replaced with a single
> argument, SUBTREE. If the value is `upper-tree', that would be
> equivalent to NODOWN non-nil; if the value is `lower-tree', that would
> be equivalent to NOUP non-nil.
I'm not sure whether there are cases where I call this with both NOUP
and NODOWN non-nil, meaning don't check the argument window's sizes and
stay within the argument window's siblings. So this would be a rather
hazardous change.
Instead I wrote a new function `window--resizable' which is a copy of
the old `window-resizable' and rewrote `window-resizable' such that it
doesn't have the NOUP and NODOWN arguments (which are only useful for
the internal workings of window resizing anyway). It now doesn't have
the TRAIL/SIDE argument either which is only needed for implementing
`adjust-window-trailing-edge'. Please have a look.
I still have to rename a number of window.el internal functions to use
the "window--" prefix.
martin
prev parent reply other threads:[~2011-11-09 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 15:10 window-resizable confusion Chong Yidong
2011-11-08 18:12 ` martin rudalics
2011-11-09 6:47 ` Chong Yidong
2011-11-09 9:45 ` martin rudalics [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBA4BA2.3030406@gmx.at \
--to=rudalics@gmx.at \
--cc=cyd@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).