From: martin rudalics <rudalics@gmx.at>
To: Christoph Scholtes <cschol2112@googlemail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Advising quit-window
Date: Wed, 26 Oct 2011 11:21:49 +0200 [thread overview]
Message-ID: <4EA7D12D.3000405@gmx.at> (raw)
In-Reply-To: <8639eg8qm6.fsf@googlemail.com>
> `q' in a keymap. However, `quit-window' is also called internally, for
> example by `quit-windows-on'. The latter is then called by vc mode to
> kill the log buffer after a commit. It took me a while to figure out
> that my advice actually caused the log buffer to be buried now, instead
> of killed.
IIRC `vc-mode' used to call `delete-windows-on' here which doesn't kill
the argument buffer. The formulation "to be buried now" strikes me as
if the buffer were killed before. Did you really observe such a change
in behavior?
martin
next prev parent reply other threads:[~2011-10-26 9:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 1:54 Advising quit-window Christoph Scholtes
2011-10-26 2:23 ` Juanma Barranquero
2011-10-26 2:52 ` Christoph Scholtes
2011-10-26 9:21 ` martin rudalics [this message]
2011-10-27 3:53 ` Christoph Scholtes
2011-10-27 9:54 ` martin rudalics
2011-10-26 13:54 ` Stefan Monnier
2011-10-27 3:55 ` Christoph Scholtes
2011-10-27 6:43 ` Juri Linkov
2011-10-27 12:06 ` Christoph Scholtes
2011-10-27 12:23 ` Stefan Monnier
2011-10-29 3:57 ` Christoph Scholtes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA7D12D.3000405@gmx.at \
--to=rudalics@gmx.at \
--cc=cschol2112@googlemail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).