From: Ergus <spacibba@aol.com>
To: emacs-devel@gnu.org, Juri Linkov <juri@linkov.net>
Cc: Philip Kaludercic <philipk@posteo.net>
Subject: Re: [PATCH] Re: Other details about completion.
Date: Tue, 05 Apr 2022 00:33:02 +0200 [thread overview]
Message-ID: <4E8D9AEF-4D7A-4B11-822F-8D0911964A05@aol.com> (raw)
In-Reply-To: <86czhw4oqr.fsf@mail.linkov.net>
[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]
BTW Juri. Do you finally plan to add the mini-buffer navigate completions features?
On April 4, 2022 9:45:00 PM GMT+02:00, Juri Linkov <juri@linkov.net> wrote:
>> May I finally add this patch to master??
>
>I don't know, maybe Philip has no time to review your patch?
>
>> On Fri, Apr 01, 2022 at 10:24:25PM +0200, Ergus wrote:
>>>Hi again...
>>>
>>>Here I attached a small patch that makes 3 small changes:
>>>
>>>1) Remove the trailing newline in completions one-column
>>>2) Use another condition in next-completion to jump to minibuffer.
>>>
>>>Normally next-completion with tabs at the end of the buffer needs an
>>>extra tab because it goes to the end of the last completion before
>>>jumping to the minibuffer or wrap.. That extra tab is because the
>>>condition to jump or wrap was eobp/bobp assuming that there is not text
>>>unproppertized after the last candidate.
>>>
>>>3) Remove a comment in switch-to-completions. That comment suggested that
>>>the next-completion action must be called inside
>>>minibuffer-completion-help but IMO that is not totally correct when
>>>completion-auto-select has some of the new values.
>>>
>>>Please, if anyone could review,correct and push I would be very
>>>grateful.
>
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
[-- Attachment #2: Type: text/html, Size: 2036 bytes --]
next prev parent reply other threads:[~2022-04-04 22:33 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220401153839.idrzrbfl2yfzga3y.ref@Ergus>
2022-04-01 15:38 ` Other details about completion Ergus
2022-04-01 16:21 ` Eli Zaretskii
2022-04-01 16:43 ` Juri Linkov
2022-04-01 16:45 ` Ergus
2022-04-01 20:24 ` [PATCH] " Ergus
2022-04-02 18:09 ` Juri Linkov
2022-04-03 0:39 ` Ergus
2022-04-04 19:35 ` Ergus
2022-04-04 19:45 ` Juri Linkov
2022-04-04 20:31 ` Philip Kaludercic
2022-04-05 11:06 ` Ergus
2022-04-04 22:33 ` Ergus [this message]
2022-04-05 19:22 ` Juri Linkov
2022-04-05 23:20 ` Ergus
2022-04-06 7:35 ` Juri Linkov
2022-04-06 13:21 ` Ergus
2022-04-06 16:48 ` Juri Linkov
2022-04-06 17:45 ` [External] : " Drew Adams
2022-04-06 18:25 ` Juri Linkov
2022-04-06 20:01 ` Drew Adams
2022-04-06 17:45 ` Ergus
2022-04-06 18:29 ` Juri Linkov
2022-04-06 19:50 ` Ergus
2022-04-07 7:35 ` Juri Linkov
2022-04-07 9:16 ` Ergus
2022-04-07 16:53 ` Juri Linkov
2022-04-07 17:38 ` Ergus
2022-04-07 18:04 ` Juri Linkov
2022-04-07 18:35 ` Ergus
2022-04-08 7:40 ` Juri Linkov
2022-04-08 8:42 ` Ergus
2022-04-08 16:20 ` [External] : " Drew Adams
2022-04-08 16:46 ` Juri Linkov
2022-04-08 9:31 ` Philip Kaludercic
2022-04-08 16:20 ` [External] : " Drew Adams
2022-04-08 16:51 ` Juri Linkov
2022-04-08 20:12 ` Philip Kaludercic
2022-04-06 23:55 ` Ergus
2022-04-06 18:13 ` Ergus
2022-04-06 18:34 ` Juri Linkov
2022-04-06 20:34 ` Ergus
2022-04-07 7:39 ` Juri Linkov
2022-04-07 9:08 ` Ergus
2022-04-07 16:50 ` Juri Linkov
2022-04-07 17:22 ` Ergus
2022-04-07 17:57 ` Juri Linkov
2022-04-07 18:27 ` Ergus
2022-04-08 7:45 ` Juri Linkov
2022-04-08 8:46 ` Ergus
2022-04-08 16:20 ` [External] : " Drew Adams
2022-04-08 16:53 ` Juri Linkov
2022-04-06 9:07 ` Lars Ingebrigtsen
2022-04-06 16:43 ` Juri Linkov
2022-04-07 11:09 ` Lars Ingebrigtsen
2022-04-07 16:46 ` Juri Linkov
2022-04-08 12:59 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8D9AEF-4D7A-4B11-822F-8D0911964A05@aol.com \
--to=spacibba@aol.com \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).