From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Deniz Dogan Newsgroups: gmane.emacs.devel Subject: Re: Reminder about feature freeze Date: Wed, 17 Aug 2011 15:48:19 +0200 Message-ID: <4E4BC6A3.40004@dogan.se> References: <8762nqf0s8.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090308080309090905080401" X-Trace: dough.gmane.org 1313588996 5047 80.91.229.12 (17 Aug 2011 13:49:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 17 Aug 2011 13:49:56 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 17 15:49:52 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QtgVD-0001Ie-Nb for ged-emacs-devel@m.gmane.org; Wed, 17 Aug 2011 15:49:51 +0200 Original-Received: from localhost ([::1]:54826 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QtgVD-0003DN-Ai for ged-emacs-devel@m.gmane.org; Wed, 17 Aug 2011 09:49:51 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:36224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QtgVA-0003D7-E7 for emacs-devel@gnu.org; Wed, 17 Aug 2011 09:49:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QtgV9-00084h-8W for emacs-devel@gnu.org; Wed, 17 Aug 2011 09:49:48 -0400 Original-Received: from ch-smtp04.sth.basefarm.net ([80.76.153.5]:36922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QtgV8-00084d-Tz for emacs-devel@gnu.org; Wed, 17 Aug 2011 09:49:47 -0400 Original-Received: from c80-216-105-155.bredband.comhem.se ([80.216.105.155]:58169 helo=[192.168.0.10]) by ch-smtp04.sth.basefarm.net with esmtp (Exim 4.76) (envelope-from ) id 1QtgUJ-0001cY-G4 for emacs-devel@gnu.org; Wed, 17 Aug 2011 15:49:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20110812 Thunderbird/6.0 In-Reply-To: <8762nqf0s8.fsf@stupidchicken.com> X-Originating-IP: 80.216.105.155 X-Scan-Result: No virus found in message 1QtgUJ-0001cY-G4. X-Scan-Signature: ch-smtp04.sth.basefarm.net 1QtgUJ-0001cY-G4 779ddc1c65ae6f6f7465fdc333c4de46 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.76.153.5 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:143367 Archived-At: This is a multi-part message in MIME format. --------------090308080309090905080401 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 2011-06-28 17:12, Chong Yidong wrote: > Just a reminder: the pretest is scheduled for late July, as discussed at > http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00953.html. > > In order to ensure a smooth transition to the pretest, I encourage > everyone who has a pending patch that implements a new feature to commit > it, or ask to have it committed, ASAP. If committing during July, > please discuss on emacs-devel first. > > If you're aware of any languishing patch that ought to be included in > Emacs 24, please point it out. Thanks. > So as I understand it we are now in the feature freeze. I have a minor addition (feature) for rcirc that I'd like to push. It adds the option to fill according to window width or a user's custom function. See the attachment. Is it okay to push this to trunk? Deniz Dogan --------------090308080309090905080401 Content-Type: text/plain; name="rcirc-window-width.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="rcirc-window-width.patch" === modified file 'lisp/net/rcirc.el' --- lisp/net/rcirc.el 2011-08-04 00:58:07 +0000 +++ lisp/net/rcirc.el 2011-08-17 13:43:29 +0000 @@ -149,7 +149,9 @@ maximum frame width." :type '(choice (const :tag "Value of `fill-column'") (const :tag "Full frame width" frame-width) - (integer :tag "Number of columns")) + (const :tag "Full window width" window-width) + (integer :tag "Number of columns") + (function :tag "Return value of function" function)) :group 'rcirc) (defcustom rcirc-fill-prefix nil @@ -2421,13 +2423,16 @@ (let ((fill-prefix (or rcirc-fill-prefix (make-string (- (point) (line-beginning-position)) ?\s))) - (fill-column (- (cond ((eq rcirc-fill-column 'frame-width) - (1- (frame-width))) - (rcirc-fill-column - rcirc-fill-column) - (t fill-column)) - ;; make sure ... doesn't cause line wrapping - 3))) + (fill-column + (cond ((eq rcirc-fill-column 'frame-width) + (1- (frame-width))) + ((eq rcirc-fill-column 'window-width) + (1- (window-width))) + ((fboundp rcirc-fill-column) ; custom function + (funcall rcirc-fill-column sender response)) + (rcirc-fill-column ; fix integer value + rcirc-fill-column) + (t fill-column)))) (fill-region (point) (point-max) nil t)))) ;;; handlers --------------090308080309090905080401--