From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: pop-to-buffer and friends new behavior or bug? Date: Sun, 19 Jun 2011 15:26:57 +0200 Message-ID: <4DFDF921.5090407@gmx.at> References: <87zklhhcys.fsf@gmail.com> <87ei2tzg3o.fsf@gmail.com> <4DFA690A.20205@gmx.at> <87d3iccuqo.fsf@gmail.com> <4DFCCDE6.30007@gmx.at> <87boxu3oic.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1308490051 22544 80.91.229.12 (19 Jun 2011 13:27:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 19 Jun 2011 13:27:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 19 15:27:27 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QYI2A-0003FC-Kq for ged-emacs-devel@m.gmane.org; Sun, 19 Jun 2011 15:27:26 +0200 Original-Received: from localhost ([::1]:53213 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYI29-0008U0-3J for ged-emacs-devel@m.gmane.org; Sun, 19 Jun 2011 09:27:25 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYI1o-0008TQ-MC for emacs-devel@gnu.org; Sun, 19 Jun 2011 09:27:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QYI1m-0008PT-OU for emacs-devel@gnu.org; Sun, 19 Jun 2011 09:27:04 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:33430) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1QYI1m-0008Ov-1V for emacs-devel@gnu.org; Sun, 19 Jun 2011 09:27:02 -0400 Original-Received: (qmail invoked by alias); 19 Jun 2011 13:27:00 -0000 Original-Received: from 62-47-36-26.adsl.highway.telekom.at (EHLO [62.47.36.26]) [62.47.36.26] by mail.gmx.net (mp065) with SMTP; 19 Jun 2011 15:27:00 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18fuUZOU74f9bB0LB6u+w9i5iTjILJPcxPMPIsfBn 5Lqt1/o+ODdxTY User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <87boxu3oic.fsf@gmail.com> X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.23 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:140669 Archived-At: > In anything, i can browse image directory without quitting anything. > This function `anything-find-files-persistent-action', use > `display-buffer' and then display image with image-dired function in > this buffer.This doesn't work anymore (display-buffer). > The image is displayed ...in minibuffer!!! > However it is working fine if i use `switch-to-buffer'. > I have commited a fix at: > http://repo.or.cz/w/anything-config.git > where you can read the code. > > To reproduce with old code (the one that use display-buffer): > M-x anything-find-files > navigate to an image directory. > hit C-u C-z on an image filename > You will have the image displayed in minibuffer and it is impossible to > quit. > > The last code is working fine. Sorry, I build without image support so I won't be able to test this. Could you please try to edebug `display-buffer-reuse-window' and find out whether the line (when (and (not (window-minibuffer-p window)) is processed in this particular case? If `window' is a minibuffer window, it should not be added to the set of candidate windows denoted by the variable `windows'. Thank you, martin PS: Basically, there would be already a bug if `window' were a minibuffer window in the test above because my first list is constructed by calling (window-list-1 nil 'nomini method-frame) where the 'nomini argument should filter out minibuffer windows.