unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Chong Yidong <cyd@stupidchicken.com>, emacs-devel@gnu.org
Subject: Re: Pretest begins end-June
Date: Wed, 01 Jun 2011 16:07:04 +0200	[thread overview]
Message-ID: <4DE64788.5060304@gmx.at> (raw)
In-Reply-To: <jwv1uzdoh3y.fsf-monnier+emacs@gnu.org>

 >> The final step will break a number of functions using buffer
 >> display routines, notably in org, gud, calculator and calendar code,
 >> which I cannot fix alone because I often don't understand the authors'
 >> intentions.  It very likely will also break external packages which I
 >> don't know like Drew's Icicles.  So I'll need some help there.
 >
 > Can you explain the kind of breakage and the reason why the change has
 > to introduce these incompatibilities?

The breakage occurs because `display-buffer' now expects that _all_
directives wrt where and how to display the buffer must be passed via a
list in the second argument (which was formerly called `other-window'
and is now called `specifiers') and the user customization of the
behavior of `display-buffer' occurs independently in a new option called
`display-buffer-alist'.

The reason for this change was one of your earlier postings

 > Rather than let-binding some Lisp-manipulated "config" var, I was
 > thinking of passing special parameters to display-buffer ...

and Juri Linkov's subsequent proposal

 > Why not use the existing argument `other-window'
 > of `pop-to-buffer' and `display-buffer'?

Hence, if an application now wants to pop up a buffer in another frame
it must do something like

(pop-to-buffer buffer-or-name 'other-frame)

instead of

(let ((pop-up-frames t))
   (pop-to-buffer buffer))

The breakage will usually cause a call like the later to simply follow
the user customizations for how to display "buffer".  I changed most of
the trivial calls already but some are rather special.

martin



  reply	other threads:[~2011-06-01 14:07 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30 16:07 Pretest begins end-June Chong Yidong
2011-05-30 18:29 ` Eli Zaretskii
2011-05-30 19:20   ` Stefan Monnier
2011-05-30 21:12     ` Eli Zaretskii
2011-05-30 22:31       ` Stefan Monnier
2011-05-31  6:11         ` Eli Zaretskii
2011-05-31 12:54           ` Stefan Monnier
2011-05-31 18:05             ` Chong Yidong
2011-05-31  7:50       ` David Kastrup
2011-05-31  9:03         ` Eli Zaretskii
2011-05-31  9:11           ` David Kastrup
2011-05-31  9:59             ` Eli Zaretskii
2011-06-04  7:47       ` Eli Zaretskii
2011-06-04 12:55         ` Stefan Monnier
2011-05-31  5:23     ` Kenichi Handa
2011-05-31  7:44     ` David Kastrup
2011-06-01  9:15 ` martin rudalics
2011-06-01 12:46   ` Stefan Monnier
2011-06-01 14:07     ` martin rudalics [this message]
2011-06-01 14:41       ` Stefan Monnier
2011-06-01 15:25         ` Drew Adams
2011-06-01 15:58           ` martin rudalics
2011-06-01 17:10             ` Drew Adams
2011-06-01 18:13               ` Stefan Monnier
2011-06-01 19:08               ` martin rudalics
2011-06-01 15:58         ` martin rudalics
2011-06-01 16:45           ` Stefan Monnier
2011-06-01 19:07             ` martin rudalics
2011-06-01 19:43               ` Stefan Monnier
2011-06-02  8:28                 ` martin rudalics
2011-06-01 15:21       ` Drew Adams
2011-06-02  8:27         ` martin rudalics
2011-06-11 18:53   ` window-safely-shrinkable-p [was Re: Pretest begins end-June] Glenn Morris
2011-06-11 20:44     ` martin rudalics
2011-06-11 22:18       ` window-safely-shrinkable-p Glenn Morris
2011-06-12  8:45         ` window-safely-shrinkable-p martin rudalics
2011-06-12  3:29       ` window-safely-shrinkable-p [was Re: Pretest begins end-June] Stefan Monnier
2011-06-12  8:45         ` martin rudalics
2011-06-14  3:01           ` Stefan Monnier
2011-06-08  3:31 ` 23.4 " Glenn Morris
2011-06-08 15:35   ` Stefan Monnier
2011-06-08 19:21     ` Daniel Colascione
2011-06-09  4:15       ` Stefan Monnier
2011-06-13 16:29 ` Pretest begins end-June Dan Nicolaescu
2011-06-13 17:19   ` Eli Zaretskii
2011-06-13 21:37   ` Chong Yidong
2011-06-14  2:58   ` Stefan Monnier
2011-06-15 14:58     ` deriving from prog-mode (was: Re: Pretest begins end-June) Dan Nicolaescu
2011-06-18 16:26       ` deriving from prog-mode Chong Yidong
2011-06-19  5:59         ` Dan Nicolaescu
2011-06-20  1:48           ` Stefan Monnier
2011-06-26 20:45             ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE64788.5060304@gmx.at \
    --to=rudalics@gmx.at \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).