From: Daniel Colascione <dan.colascione@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Fixing Windows and DOS command line argument quoting
Date: Mon, 25 Apr 2011 11:24:08 -0700 [thread overview]
Message-ID: <4DB5BC48.6060605@gmail.com> (raw)
In-Reply-To: <4DB53599.8040703@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
On 4/25/11 1:49 AM, Daniel Colascione wrote:
>> . Please install this only on the trunk. The emacs-23 branch should
>> not be destabilized by such experiments at this time.
>
> Fair enough.
I'd just like to note that it'd be a good idea to eventually backport
this fix to Emacs 23: it's a security issue. The current
shell-quote-argument doesn't, so (shell-command (format "cmd %s"
(shell-quote-argument untrusted-input))) can run an arbitrary command.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2011-04-25 18:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 2:09 Fixing Windows and DOS command line argument quoting Daniel Colascione
2011-04-25 6:41 ` Eli Zaretskii
2011-04-25 8:49 ` Daniel Colascione
2011-04-25 8:58 ` Jason Rumney
2011-04-25 9:15 ` Eli Zaretskii
2011-04-25 9:22 ` Daniel Colascione
2011-04-25 17:56 ` Daniel Colascione
2011-04-25 18:47 ` Eli Zaretskii
2011-04-26 10:44 ` Daniel Colascione
2011-04-26 17:50 ` Eli Zaretskii
2011-04-25 9:35 ` Eli Zaretskii
2011-04-25 18:24 ` Daniel Colascione [this message]
2011-04-25 18:48 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2011-04-27 0:58 Ben Key
2011-04-27 1:25 ` Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB5BC48.6060605@gmail.com \
--to=dan.colascione@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).