From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Andrew Helsley <helsleya@cs.ucr.edu>, emacs-devel@gnu.org
Subject: Re: Completion: minibuffer.el vs comint.el
Date: Tue, 29 Mar 2011 11:14:17 +0200 [thread overview]
Message-ID: <4D91A2E9.9070409@gmx.at> (raw)
In-Reply-To: <jwvei5rpcfm.fsf-monnier+emacs@gnu.org>
>> I think it may become dedicated in the function `minibuffer-completion-help'
>> in `minibuffer.el'. Notice the local binding of the variable
>> display-buffer-mark-dedicated'. From the documentation of the variable:
>
>> If non-nil, `display-buffer' marks the windows it creates as dedicated.
>
>> `display-buffer' itself is called from the `with-output-to-temp-buffer' C
>> function (at least that is what `with-output-...'s docs suggest).
>
>> Unfortunately as for intent/reason behind this behavior, I don't have
>> a clue.
>
> This is so as to know whether to delete the window when the *Completions*
> buffer is hidden/buried.
>
> Maybe we should use another approach (hi Martin ;-). E.g. just add
> a flag "created for *Completions*" when we create the window, that would
> work similarly to `dedicated' w.r.t bury-buffer but which would not
> prevent display-buffer from reusing that window for some other buffer.
The dedicated window method works well for displaying a buffer in a
separate frame or a new window. It can't be used when a window is
reused for displaying the buffer. In my branch `display-buffer' always
records the previous state and burying the buffer or quitting the window
conveniently restores the previous state. So when you dedicate a window
to its buffer you exclusively do that because you do not want to display
another buffer in that window.
martin
next prev parent reply other threads:[~2011-03-29 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101114173358.683A6628353@mail.cs.ucr.edu>
2010-11-15 21:56 ` Completion: minibuffer.el vs comint.el Andrew Helsley
2011-03-28 14:11 ` Stefan Monnier
2011-03-29 9:14 ` martin rudalics [this message]
2011-03-29 13:39 ` Stefan Monnier
2011-03-29 15:18 ` martin rudalics
2011-03-29 20:55 ` Stefan Monnier
2010-11-14 16:44 Андрей Парамонов
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D91A2E9.9070409@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=helsleya@cs.ucr.edu \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).