From: Christoph Scholtes <cschol2112@googlemail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: New function: vc-ediff
Date: Thu, 10 Mar 2011 21:38:14 -0700 [thread overview]
Message-ID: <4D79A736.6080707@gmail.com> (raw)
In-Reply-To: <jwvpqpzezms.fsf-monnier+emacs@gnu.org>
Hi Stefan,
On 3/10/2011 9:00 AM, Stefan Monnier wrote:
> I think vc-ediff should not require any changes to ediff.
> You can check pcvs.el for an example of code that provides similar
> functionality without any ediff changes.
I saw that, but I honestly didn't like this implementation. I felt using
`ediff-buffers' I would need to duplicate code that had already been
written, namely in `ediff-revision'.
I figured, what I needed for 'vc-diff' is basically `ediff-revision',
but without the interactive prompts for revisions. Unfortunately, the
function does not work that way. So I factored out the interactive piece
from the piece I would need for `vc-ediff'. The refactoring in
`ediff.el' is minimal just exposes an internal, non-interactive function
for other functions besides `ediff-revision' to use.
Ultimately, `ediff-(vc|rcs)-internal', which is called by
`ediff-revision', uses `ediff-buffers', like the implementation in
`pcvs.el'.
Is there any specific reason why the refactoring in `ediff.el' should
not be done?
Christoph
next prev parent reply other threads:[~2011-03-11 4:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 4:20 New function: vc-ediff Christoph Scholtes
2011-03-10 16:00 ` Stefan Monnier
2011-03-11 4:38 ` Christoph Scholtes [this message]
2011-03-11 20:15 ` Stefan Monnier
2011-03-12 8:38 ` Eli Zaretskii
2011-03-12 15:05 ` Christoph Scholtes
2011-03-12 17:49 ` Eli Zaretskii
2011-03-12 20:44 ` Stefan Monnier
2011-03-12 20:48 ` Eli Zaretskii
2011-03-12 21:27 ` Stefan Monnier
2011-03-19 2:24 ` Christoph Scholtes
2011-03-20 2:45 ` Stefan Monnier
2011-03-22 4:46 ` Christoph Scholtes
2011-03-27 16:03 ` Christoph Scholtes
2011-03-27 20:58 ` Stefan Monnier
2011-03-29 2:42 ` Christoph Scholtes
2011-03-29 13:46 ` Stefan Monnier
2011-03-30 3:02 ` Christoph Scholtes
2011-04-08 1:16 ` Christoph Scholtes
2011-04-17 19:04 ` Christoph Scholtes
2011-04-20 17:39 ` Stefan Monnier
2011-04-20 22:20 ` Christoph Scholtes
2011-03-13 16:16 ` Uday S Reddy
2011-03-13 18:01 ` Eli Zaretskii
2011-03-13 21:35 ` Stefan Monnier
2011-03-13 22:58 ` Christoph Scholtes
2011-03-12 15:11 ` Christoph Scholtes
2011-03-12 21:25 ` Stefan Monnier
2011-03-11 4:12 ` Michael Welsh Duggan
2011-03-11 4:44 ` Christoph Scholtes
2011-03-11 7:46 ` Uday S Reddy
2011-03-11 8:16 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D79A736.6080707@gmail.com \
--to=cschol2112@googlemail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).