From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christoph Newsgroups: gmane.emacs.devel Subject: Re: How many more gnulib imports? Date: Sun, 20 Feb 2011 16:32:08 -0700 Message-ID: <4D61A478.3000603@gmail.com> References: <4D60F860.6020303@cs.ucla.edu> <4D613998.6000607@gmail.com> <4D613DB1.9030705@gmail.com> <83mxlqty36.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040202020604070900030401" X-Trace: dough.gmane.org 1298244746 14153 80.91.229.12 (20 Feb 2011 23:32:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 20 Feb 2011 23:32:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 21 00:32:22 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PrIlJ-0002yh-Pa for ged-emacs-devel@m.gmane.org; Mon, 21 Feb 2011 00:32:22 +0100 Original-Received: from localhost ([127.0.0.1]:34143 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrIlJ-0001fs-5G for ged-emacs-devel@m.gmane.org; Sun, 20 Feb 2011 18:32:21 -0500 Original-Received: from [140.186.70.92] (port=37657 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrIlF-0001db-7P for emacs-devel@gnu.org; Sun, 20 Feb 2011 18:32:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrIlE-0001AV-0c for emacs-devel@gnu.org; Sun, 20 Feb 2011 18:32:17 -0500 Original-Received: from mail-gx0-f175.google.com ([209.85.161.175]:32801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrIlB-0001AD-LN; Sun, 20 Feb 2011 18:32:13 -0500 Original-Received: by gxk1 with SMTP id 1so2176731gxk.34 for ; Sun, 20 Feb 2011 15:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=H5v66mMrrEHKG8U/sUGdqhHoP0kVYGKnDPh/CKZ7O2Q=; b=HSEbKbMBElJR5g+Wac+caDRUrMGO4ISoVcF61c1reWigWrV2t9Q4sGW+uKGvIo9dXg yV74kE9ftu4EKtAx0Xx4yFmnDJ6CS/N1b85s4PVDBmxSgknRujKD4Jr/GJeSCIMxxfkh DW/uDFoeI6Y4XZw4yrTfkf/Ldy7+37gGcVB8U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; b=q6N2BeK+LcVl8riOjOHdAgWSFeWrl1istdeFF8czX4Qx3VTyr0tTQQpxigpQxulFnh ++BDusP4mWLfBv2gJA/mVHEY/lrQCoSh5UiP6HOrwEOz6zGGxlp7sCbmMpGW/jT4zHe4 Iqj9zVE1TgACWmDpHPHyiJiPOGQJCn0fsNWds= Original-Received: by 10.90.89.3 with SMTP id m3mr981811agb.120.1298244733014; Sun, 20 Feb 2011 15:32:13 -0800 (PST) Original-Received: from [192.168.1.4] (71-208-192-11.hlrn.qwest.net [71.208.192.11]) by mx.google.com with ESMTPS id c7sm5923018ana.37.2011.02.20.15.32.11 (version=SSLv3 cipher=OTHER); Sun, 20 Feb 2011 15:32:12 -0800 (PST) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 In-Reply-To: <83mxlqty36.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136301 Archived-At: This is a multi-part message in MIME format. --------------040202020604070900030401 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi Eli On 2/20/2011 10:28 AM, Eli Zaretskii wrote: > However, this change will only work with MinGW, since it has stdint.h. > To make it work with MSVC, we need to add nt/inc/stdint.h, and make > lib/md5.$(O) depend on it. For MinGW, nt/inc/stdint.h could just say > "#include_next" (conditioned on __GNUC__ being non-zero). > Otherwise, it should include the minimum needed for md5.c to compile. > Paul said a few messages ago that all that's needed for now is this: > > typedef unsigned int uint32_t; > > Could you please commit such a followup change, after you test it (see > below)? If not, I will get to it in due time. See attached patch. > To test this change (assuming you don't have MSVC -- neither do I, > btw), rename MinGW's stdint.h in the MinGW include directory, create > an nt/inc/stdint.h that has just the above 1 line, and then try > building with MinGW. Any compilation error/warning you see probably > means that more stuff needs to be added to nt/inc/stdint.h. I tested it as follows: Renamed MinGWs stdint.h to _stdint.h. Verified mingw32-make fails because it cannot find stdint.h. Changed line "#ifdef __GNUC__" in nt/inc/stdint.h to "#ifndef __GNUC__" to force it to execute #else branch. mingw32-make clean, mingw32-make compiles without errors or warnings. Then, of course I changed the line back to "#ifdef __GNUC__" before creating the patch. :) Christoph --------------040202020604070900030401 Content-Type: text/plain; name="stdint-v1.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="stdint-v1.txt" PT09IG1vZGlmaWVkIGZpbGUgJ0NoYW5nZUxvZycKLS0tIENoYW5nZUxvZwkyMDExLTAyLTIw IDIxOjA5OjQ1ICswMDAwCisrKyBDaGFuZ2VMb2cJMjAxMS0wMi0yMCAyMzoyNzo0NCArMDAw MApAQCAtMSwzICsxLDExIEBACisyMDExLTAyLTIwICBDaHJpc3RvcGggU2Nob2x0ZXMgIDxj c2Nob2wyMTEyQGdtYWlsLmNvbT4KKworCSogbGliL21ha2VmaWxlLnczMi1pbjogKCQoQkxE KS9tZDUuJChPKSk6IEFkZGVkIGRlcGVuZGVuY3kgb24KKwkkKEVNQUNTX1JPT1QpL250L2lu Yy9zdGRpbnQuaC4KKworCSogbnQvaW5jL3N0ZGludC5oOiBBZGRlZCB0byBzdXBwb3J0IGNv bXBpbGF0aW9uIHdpdGggdG9vbCBjaGFpbnMKKwl0aGF0IGRvIG5vdCBoYXZlIHN0ZGludC5o IChlLmcuIE1TVkMpLgorCiAyMDExLTAyLTIwICBFbGkgWmFyZXRza2lpICA8ZWxpekBnbnUu b3JnPgogCiAJKiBsaWIvbWFrZWZpbGUudzMyLWluICgkKEJMRCkvbWQ1LiQoTykpOiBEb24n dCBkZXBlbmQgb24KCj09PSBtb2RpZmllZCBmaWxlICdsaWIvbWFrZWZpbGUudzMyLWluJwot LS0gbGliL21ha2VmaWxlLnczMi1pbgkyMDExLTAyLTIwIDIxOjA5OjQ1ICswMDAwCisrKyBs aWIvbWFrZWZpbGUudzMyLWluCTIwMTEtMDItMjAgMjM6MjI6NDIgKzAwMDAKQEAgLTk5LDYg Kzk5LDcgQEAKIAkkKEVNQUNTX1JPT1QpL3NyYy9zL21zLXczMi5oIFwKIAkkKEVNQUNTX1JP T1QpL3NyYy9tL2ludGVsMzg2LmggXAogCSQoRU1BQ1NfUk9PVCkvc3JjL2NvbmZpZy5oIFwK KwkkKEVNQUNTX1JPT1QpL250L2luYy9zdGRpbnQuaCBcCiAJJChFTUFDU19ST09UKS9saWIv bWQ1LmgKIAogIyBUaGUgZm9sbG93aW5nIGRlcGVuZGVuY2llcyBhcmUgZm9yIHN1cHBvcnRp bmcgcGFyYWxsZWwgYnVpbGRzLCB3aGVyZQoKPT09IG1vZGlmaWVkIGZpbGUgJ250L0NoYW5n ZUxvZycKLS0tIG50L0NoYW5nZUxvZwkyMDExLTAyLTA5IDIwOjUwOjE3ICswMDAwCisrKyBu dC9DaGFuZ2VMb2cJMjAxMS0wMi0yMCAyMzoyODo1MSArMDAwMApAQCAtMSwzICsxLDggQEAK KzIwMTEtMDItMjAgIENocmlzdG9waCBTY2hvbHRlcyAgPGNzY2hvbDIxMTJAZ21haWwuY29t PgorCisJKiBpbmMvc3RkaW50Lmg6IEFkZGVkIHRvIHN1cHBvcnQgY29tcGlsYXRpb24gd2l0 aCB0b29sIGNoYWlucyB0aGF0CisJZG8gbm90IGhhdmUgc3RkaW50LmggKGUuZy4gTVNWQyku CisKIDIwMTEtMDItMDkgIEVsaSBaYXJldHNraWkgIDxlbGl6QGdudS5vcmc+CiAKIAkqIG1h a2VmaWxlLnczMi1pbiAoYm9vdHN0cmFwLW5tYWtlLCBib290c3RyYXAtZ21ha2UpOiBNYWtl IHRoZQoKPT09IGFkZGVkIGZpbGUgJ250L2luYy9zdGRpbnQuaCcKLS0tIG50L2luYy9zdGRp bnQuaAkxOTcwLTAxLTAxIDAwOjAwOjAwICswMDAwCisrKyBudC9pbmMvc3RkaW50LmgJMjAx MS0wMi0yMCAyMzoxMToxNCArMDAwMApAQCAtMCwwICsxLDM0IEBACisvKiBSZXBsYWNlbWVu dCBzdGRpbnQuaCBmaWxlIGZvciBidWlsZGluZyBHTlUgRW1hY3Mgb24gV2luZG93cy4NCisN CitDb3B5cmlnaHQgKEMpIDIwMTEgIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLg0K Kw0KK1RoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBFbWFjcy4NCisNCitHTlUgRW1hY3MgaXMg ZnJlZSBzb2Z0d2FyZTogeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQ0K K2l0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2Ug YXMgcHVibGlzaGVkIGJ5DQordGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgZWl0aGVy IHZlcnNpb24gMyBvZiB0aGUgTGljZW5zZSwgb3INCisoYXQgeW91ciBvcHRpb24pIGFueSBs YXRlciB2ZXJzaW9uLg0KKw0KK0dOVSBFbWFjcyBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9w ZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLA0KK2J1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsg d2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mDQorTUVSQ0hBTlRBQklMSVRZ IG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQ0KK0dOVSBH ZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuDQorDQorWW91IHNob3Vs ZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vu c2UNCithbG9uZyB3aXRoIEdOVSBFbWFjcy4gIElmIG5vdCwgc2VlIDxodHRwOi8vd3d3Lmdu dS5vcmcvbGljZW5zZXMvPi4gICovDQorDQorI2lmbmRlZiBfTlRfU1RESU5UX0hfDQorI2Rl ZmluZSBfTlRfU1RESU5UX0hfDQorDQorI2lmZGVmIF9fR05VQ19fDQorIyBpbmNsdWRlX25l eHQgPHN0ZGludC5oPiAvKiB1c2Ugc3RkaW50LmggaWYgYXZhaWxhYmxlICovDQorI2Vsc2UN CisNCisvKiBNaW5pbXVtIGRlZmluaXRpb25zIHRvIGFsbG93IGNvbXBpbGF0aW9uIHdpdGgg dG9vbCBjaGFpbnMgd2hlcmUNCisgICBzdGRpbnQuaCBpcyBub3QgYXZhaWxhYmxlLCBlLmcu IE1pY3Jvc29mdCBWaXN1YWwgU3R1ZGlvLiAqLw0KKw0KK3R5cGVkZWYgdW5zaWduZWQgaW50 IHVpbnQzMl90Ow0KKw0KKyNlbmRpZg0KKw0KKyNlbmRpZiAvKiBfTlRfU1RESU5UX0hfICov DQoK --------------040202020604070900030401--