From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: draft patch to import gnulib's filemode module into Emacs Date: Sun, 20 Feb 2011 09:18:15 -0800 Organization: UCLA Computer Science Department Message-ID: <4D614CD7.1050703@cs.ucla.edu> References: <4D60F860.6020303@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1298222319 5623 80.91.229.12 (20 Feb 2011 17:18:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 20 Feb 2011 17:18:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 20 18:18:34 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PrCva-00047h-4y for ged-emacs-devel@m.gmane.org; Sun, 20 Feb 2011 18:18:34 +0100 Original-Received: from localhost ([127.0.0.1]:50423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrCvZ-0004tk-Dv for ged-emacs-devel@m.gmane.org; Sun, 20 Feb 2011 12:18:33 -0500 Original-Received: from [140.186.70.92] (port=43773 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrCvT-0004sS-IW for emacs-devel@gnu.org; Sun, 20 Feb 2011 12:18:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrCvS-0005YY-K5 for emacs-devel@gnu.org; Sun, 20 Feb 2011 12:18:27 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:47214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrCvQ-0005Xx-SZ; Sun, 20 Feb 2011 12:18:25 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id E3EC639E80E1; Sun, 20 Feb 2011 09:18:22 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xmd6FnaA0U5J; Sun, 20 Feb 2011 09:18:22 -0800 (PST) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 91CBC39E80DC; Sun, 20 Feb 2011 09:18:22 -0800 (PST) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136285 Archived-At: My filemode patch had a problem, in that it relied on an implicit function declaration on many hosts. The following patch fixes this. === modified file 'src/dired.c' --- src/dired.c 2011-02-20 10:53:22 +0000 +++ src/dired.c 2011-02-20 17:14:24 +0000 @@ -54,8 +54,6 @@ #include #include -#include - #define DIRENTRY struct direct extern DIR *opendir (char *); @@ -63,6 +61,8 @@ #endif /* HAVE_DIRENT_H */ +#include + #ifdef MSDOS #define DIRENTRY_NONEMPTY(p) ((p)->d_name[0] != 0) #else