From: Christoph <cschol2112@googlemail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>,
emacs-devel@gnu.org
Subject: Re: How many more gnulib imports?
Date: Sun, 20 Feb 2011 09:13:37 -0700 [thread overview]
Message-ID: <4D613DB1.9030705@gmail.com> (raw)
In-Reply-To: <4D613998.6000607@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 307 bytes --]
On 2/20/2011 8:56 AM, I wrote:
> In regards to the md5 change, I think I have a patch to fix the Windows
> build. I will send it for review once my bootstrap finishes and I see
> everything works. Shouldn't be too long.
Find the patch fixing the Windows build for including lib/md5.c attached.
Christoph
[-- Attachment #2: md5-fix-v1.txt --]
[-- Type: text/plain, Size: 2429 bytes --]
=== modified file 'lib/makefile.w32-in'
--- lib/makefile.w32-in 2011-01-31 19:36:08 +0000
+++ lib/makefile.w32-in 2011-02-20 15:49:09 +0000
@@ -27,7 +27,8 @@
$(BLD)/getopt.$(O) \
$(BLD)/getopt1.$(O) \
$(BLD)/strftime.$(O) \
- $(BLD)/time_r.$(O)
+ $(BLD)/time_r.$(O) \
+ $(BLD)/md5.$(O)
#
# Build the library
@@ -93,6 +94,14 @@
$(EMACS_ROOT)/src/m/intel386.h \
$(EMACS_ROOT)/src/config.h
+$(BLD)/md5.$(O) : \
+ $(EMACS_ROOT)/lib/md5.c \
+ $(EMACS_ROOT)/src/s/ms-w32.h \
+ $(EMACS_ROOT)/src/m/intel386.h \
+ $(EMACS_ROOT)/src/config.h \
+ $(EMACS_ROOT)/nt/inc/sys/stat.h \
+ $(EMACS_ROOT)/lib/md5.h
+
# The following dependencies are for supporting parallel builds, where
# we must make sure $(BLD) exists before any compilation starts.
#
=== modified file 'src/ChangeLog'
--- src/ChangeLog 2011-02-20 08:48:52 +0000
+++ src/ChangeLog 2011-02-20 16:08:30 +0000
@@ -1,3 +1,8 @@
+2011-02-20 Christoph Scholtes <cschol2112@gmail.com>
+
+ * makefile.w32-in: Remove md5.$(O).
+ ($(BLD)/md5.$(O)): Remove prerequisites.
+
2011-02-20 Paul Eggert <eggert@cs.ucla.edu>
Import crypto/md5 and stdint modules from gnulib.
=== modified file 'src/makefile.w32-in'
--- src/makefile.w32-in 2011-02-09 20:50:17 +0000
+++ src/makefile.w32-in 2011-02-20 15:43:20 +0000
@@ -81,7 +81,6 @@
$(BLD)/lread.$(O) \
$(BLD)/macros.$(O) \
$(BLD)/marker.$(O) \
- $(BLD)/md5.$(O) \
$(BLD)/minibuf.$(O) \
$(BLD)/w32.$(O) \
$(BLD)/w32heap.$(O) \
@@ -221,7 +220,7 @@
syntax.c bytecode.c \
process.c callproc.c unexw32.c \
region-cache.c sound.c atimer.c \
- doprnt.c intervals.c textprop.c composite.c md5.c
+ doprnt.c intervals.c textprop.c composite.c
SOME_MACHINE_OBJECTS = dosfns.o msdos.o \
xterm.o xfns.o xmenu.o xselect.o xrdb.o xsmfns.o dbusbind.o
obj = $(GLOBAL_SOURCES:.c=.o)
@@ -843,6 +842,7 @@
$(EMACS_ROOT)/nt/inc/nl_types.h \
$(EMACS_ROOT)/nt/inc/unistd.h \
$(EMACS_ROOT)/nt/inc/sys/time.h \
+ $(EMACS_ROOT)/lib/md5.h \
$(LISP_H) \
$(SRC)/atimer.h \
$(SRC)/blockinput.h \
@@ -856,7 +856,6 @@
$(SRC)/intervals.h \
$(SRC)/keyboard.h \
$(SRC)/keymap.h \
- $(SRC)/md5.h \
$(SRC)/systime.h \
$(SRC)/w32gui.h \
$(SRC)/window.h
@@ -1135,11 +1134,6 @@
$(SRC)/buffer.h \
$(SRC)/character.h
-$(BLD)/md5.$(O) : \
- $(SRC)/md5.c \
- $(CONFIG_H) \
- $(SRC)/md5.h
-
$(BLD)/menu.$(O) : \
$(SRC)/menu.c \
$(CONFIG_H) \
next prev parent reply other threads:[~2011-02-20 16:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 11:17 draft patch to import gnulib's filemode module into Emacs Paul Eggert
2011-02-20 12:42 ` Eli Zaretskii
2011-02-20 17:18 ` Paul Eggert
2011-02-21 17:58 ` Paul Eggert
2011-02-20 12:43 ` How many more gnulib imports? (was: draft patch to import gnulib's filemode module into Emacs) Eli Zaretskii
2011-02-20 15:56 ` How many more gnulib imports? Christoph
2011-02-20 16:13 ` Christoph [this message]
2011-02-20 17:28 ` Eli Zaretskii
2011-02-20 17:54 ` Christoph
2011-02-20 18:54 ` Eli Zaretskii
2011-02-20 23:32 ` Christoph
2011-02-21 16:00 ` Christoph
2011-02-21 19:05 ` Eli Zaretskii
2011-02-21 19:10 ` Christoph
2011-02-21 20:19 ` Eli Zaretskii
2011-02-21 20:21 ` Eli Zaretskii
2011-02-20 17:46 ` Paul Eggert
2011-02-20 17:54 ` Eli Zaretskii
2011-02-20 18:06 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D613DB1.9030705@gmail.com \
--to=cschol2112@googlemail.com \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).