From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: attribute warn_unused_result Date: Sat, 05 Feb 2011 23:04:04 -0800 Organization: UCLA Computer Science Department Message-ID: <4D4E47E4.10809@cs.ucla.edu> References: <83r5bobz2k.fsf@gnu.org> <4D4B4EEA.50907@cs.ucla.edu> <83hbckb3u4.fsf@gnu.org> <83zkqbah6c.fsf@gnu.org> <4D4C95B8.6010001@cs.ucla.edu> <4D4DFAB9.10609@cs.ucla.edu> <83sjw1957e.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1296975860 24297 80.91.229.12 (6 Feb 2011 07:04:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 6 Feb 2011 07:04:20 +0000 (UTC) Cc: cyd@stupidchicken.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 06 08:04:15 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PlyfP-0001iR-3m for ged-emacs-devel@m.gmane.org; Sun, 06 Feb 2011 08:04:15 +0100 Original-Received: from localhost ([127.0.0.1]:59486 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PlyfO-0006h3-7u for ged-emacs-devel@m.gmane.org; Sun, 06 Feb 2011 02:04:14 -0500 Original-Received: from [140.186.70.92] (port=45135 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PlyfJ-0006gu-NP for emacs-devel@gnu.org; Sun, 06 Feb 2011 02:04:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PlyfI-0006FL-H6 for emacs-devel@gnu.org; Sun, 06 Feb 2011 02:04:09 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:41005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PlyfH-0006El-16; Sun, 06 Feb 2011 02:04:07 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 7C7BD39E80DB; Sat, 5 Feb 2011 23:04:05 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9ts1OsETNpEY; Sat, 5 Feb 2011 23:04:04 -0800 (PST) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id BF65839E8083; Sat, 5 Feb 2011 23:04:04 -0800 (PST) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 In-Reply-To: <83sjw1957e.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135636 Archived-At: On 02/05/2011 08:07 PM, Eli Zaretskii wrote: > MS-Windows already works with lib/ignore-value.h (your change in > sysdep.c already used it). So there's no need to use #ifndef DOS_NT > in this case. I don't see how the following patch could possibly work on Windows. Although it would compile, surely it would break things badly if the call to chdir () fails on Windows. Have you tested it for that case? === modified file 'src/sysdep.c' --- src/sysdep.c 2011-02-06 01:25:41 +0000 +++ src/sysdep.c 2011-02-06 06:57:13 +0000 @@ -550,10 +550,8 @@ sys_subshell (void) /* Use our buffer's default directory for the subshell. */ if (str && chdir ((char *) str) != 0) { -#ifndef DOS_NT ignore_value (write (1, "Can't chdir\n", 12)); _exit (1); -#endif } close_process_descs (); /* Close Emacs's pipes/ptys */