From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: cyd@stupidchicken.com, emacs-devel@gnu.org
Subject: Re: attribute warn_unused_result
Date: Sat, 05 Feb 2011 23:04:04 -0800 [thread overview]
Message-ID: <4D4E47E4.10809@cs.ucla.edu> (raw)
In-Reply-To: <83sjw1957e.fsf@gnu.org>
On 02/05/2011 08:07 PM, Eli Zaretskii wrote:
> MS-Windows already works with lib/ignore-value.h (your change in
> sysdep.c already used it). So there's no need to use #ifndef DOS_NT
> in this case.
I don't see how the following patch could possibly work on Windows.
Although it would compile, surely it would break things badly if
the call to chdir () fails on Windows. Have you tested it for
that case?
=== modified file 'src/sysdep.c'
--- src/sysdep.c 2011-02-06 01:25:41 +0000
+++ src/sysdep.c 2011-02-06 06:57:13 +0000
@@ -550,10 +550,8 @@ sys_subshell (void)
/* Use our buffer's default directory for the subshell. */
if (str && chdir ((char *) str) != 0)
{
-#ifndef DOS_NT
ignore_value (write (1, "Can't chdir\n", 12));
_exit (1);
-#endif
}
close_process_descs (); /* Close Emacs's pipes/ptys */
next prev parent reply other threads:[~2011-02-06 7:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 14:57 attribute warn_unused_result Eli Zaretskii
2011-02-03 18:53 ` Stefan Monnier
2011-02-03 19:33 ` Paul Eggert
2011-02-03 20:42 ` Chad Brown
2011-02-03 21:30 ` Eli Zaretskii
2011-02-03 21:58 ` Paul Eggert
2011-02-04 0:17 ` Lennart Borgman
2011-02-04 8:18 ` Eli Zaretskii
2011-02-05 16:30 ` Chong Yidong
2011-02-03 21:40 ` Paul Eggert
2011-02-04 8:41 ` Eli Zaretskii
2011-02-04 8:51 ` Paul Eggert
2011-02-04 21:05 ` Stefan Monnier
2011-02-05 8:50 ` Eli Zaretskii
2011-02-03 21:47 ` Lennart Borgman
2011-02-04 21:08 ` Stefan Monnier
2011-02-04 21:15 ` Lennart Borgman
2011-02-05 9:03 ` Eli Zaretskii
2011-02-05 8:59 ` Eli Zaretskii
2011-02-03 22:08 ` Andy Moreton
2011-02-03 23:00 ` Paul Eggert
2011-02-03 21:16 ` Eli Zaretskii
2011-02-03 21:14 ` Eli Zaretskii
2011-02-04 0:57 ` Paul Eggert
2011-02-04 8:29 ` Eli Zaretskii
2011-02-04 15:50 ` Tom Tromey
2011-02-04 16:38 ` Eli Zaretskii
2011-02-04 17:12 ` Tom Tromey
2011-02-05 0:11 ` Paul Eggert
2011-02-05 9:18 ` Eli Zaretskii
[not found] ` <yyxvd0yxwv1.fsf@fencepost.gnu.org>
2011-02-06 1:34 ` Paul Eggert
2011-02-06 4:07 ` Eli Zaretskii
2011-02-06 7:04 ` Paul Eggert [this message]
2011-02-06 10:21 ` Eli Zaretskii
2011-02-06 18:58 ` Paul Eggert
2011-02-06 19:27 ` Eli Zaretskii
2011-02-06 20:11 ` Paul Eggert
2011-02-06 21:26 ` Eli Zaretskii
2011-02-04 21:14 ` Stefan Monnier
2011-02-05 8:57 ` Eli Zaretskii
2011-02-05 16:01 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4E47E4.10809@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).