From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: attribute warn_unused_result Date: Fri, 04 Feb 2011 00:51:11 -0800 Organization: UCLA Computer Science Department Message-ID: <4D4BBDFF.5030901@cs.ucla.edu> References: <4D4B02EF.1080708@cs.ucla.edu> <7C616374-F2D6-4797-A66C-9C4D293B93B6@mit.edu> <4D4B20C5.1070100@cs.ucla.edu> <83bp2sb39f.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1296809506 8803 80.91.229.12 (4 Feb 2011 08:51:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 4 Feb 2011 08:51:46 +0000 (UTC) Cc: yandros@MIT.EDU, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 04 09:51:41 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PlHOH-0002RB-47 for ged-emacs-devel@m.gmane.org; Fri, 04 Feb 2011 09:51:41 +0100 Original-Received: from localhost ([127.0.0.1]:50789 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PlHOG-0004gS-KB for ged-emacs-devel@m.gmane.org; Fri, 04 Feb 2011 03:51:40 -0500 Original-Received: from [140.186.70.92] (port=35838 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PlHNw-0004fl-QU for emacs-devel@gnu.org; Fri, 04 Feb 2011 03:51:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PlHNv-0001zR-Vb for emacs-devel@gnu.org; Fri, 04 Feb 2011 03:51:20 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:60922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PlHNt-0001y1-Rw; Fri, 04 Feb 2011 03:51:18 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id C3B0339E80F8; Fri, 4 Feb 2011 00:51:16 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DcyF8AS7wrLs; Fri, 4 Feb 2011 00:51:16 -0800 (PST) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 6A25C39E8083; Fri, 4 Feb 2011 00:51:16 -0800 (PST) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 In-Reply-To: <83bp2sb39f.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135565 Archived-At: On 02/04/2011 12:41 AM, Eli Zaretskii wrote: > The -Wno-unused-result compiler options looks easy to me, and is IMO > cleaner than using ignore-value.h. Heck, even the corresponding > pragma in the affected source files looks cleaner. Unfortunately those approaches shut off all instances of the warnings, even the useful ones. I wouldn't have found the eight bugs fixed in BZR 102952 if I hadn't had those warnings. Like I said, though, I don't much like ignore_value, and either of the above approaches would also be fine with me.