From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Blake Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Re: syncing Emacs from sources maintained elsewhere Date: Wed, 19 Jan 2011 17:27:47 -0700 Organization: Red Hat Message-ID: <4D378183.8030001@redhat.com> References: <4D2BA939.5090903@cs.ucla.edu> <4D34A88F.4080400@cs.ucla.edu> <4D35D842.5030003@cs.ucla.edu> <4D367F0B.3040808@cs.ucla.edu> <4D368D16.7020702@swipnet.se> <25y66hjmiu.fsf@fencepost.gnu.org> <4D36BF43.3050007@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig7806E1EBC9BCE44EBA8473C8" X-Trace: dough.gmane.org 1295483297 8571 80.91.229.12 (20 Jan 2011 00:28:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 20 Jan 2011 00:28:17 +0000 (UTC) Cc: Glenn Morris , bug-gnulib , 7859@debbugs.gnu.org, 7856@debbugs.gnu.org, emacs-devel@gnu.org To: Paul Eggert Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Thu Jan 20 01:28:12 2011 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PfiNn-0005ry-Ii for gnu-bug-gnulib@m.gmane.org; Thu, 20 Jan 2011 01:28:11 +0100 Original-Received: from localhost ([127.0.0.1]:33631 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PfiNm-0007dk-V1 for gnu-bug-gnulib@m.gmane.org; Wed, 19 Jan 2011 19:28:10 -0500 Original-Received: from [140.186.70.92] (port=60581 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PfiNf-0007db-Hk for bug-gnulib@gnu.org; Wed, 19 Jan 2011 19:28:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PfiNe-0002nv-Mi for bug-gnulib@gnu.org; Wed, 19 Jan 2011 19:28:03 -0500 Original-Received: from mx1.redhat.com ([209.132.183.28]:44762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PfiNb-0002mz-5H; Wed, 19 Jan 2011 19:27:59 -0500 Original-Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0K0Rndk001840 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Jan 2011 19:27:49 -0500 Original-Received: from [10.3.113.109] (ovpn-113-109.phx2.redhat.com [10.3.113.109]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p0K0RmYV001131; Wed, 19 Jan 2011 19:27:48 -0500 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 In-Reply-To: <4D36BF43.3050007@cs.ucla.edu> X-Enigmail-Version: 1.1.2 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Xref: news.gmane.org gmane.comp.lib.gnulib.bugs:24810 gmane.emacs.devel:134791 Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7806E1EBC9BCE44EBA8473C8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/19/2011 03:38 AM, Paul Eggert wrote: > * unexmacosx.c includes the Gnulib . That's always a bug to include any gnulib-provided header prior to . >=20 > * And when Gnulib declares a 'struct option', this clashes > with the 'struct option' declared in the system getopt.h. And this is a known symptom of violating the above constraint. > =20 > PS. This all seems to be a case where we should be using Gnulib's > identifier replacement mechanism, but I don't understand it that > well and if memory serves it doesn't work with struct tags anyway. We've managed to modernize other headers to properly declare replacement structs exactly once; it is merely a matter of someone having enough time to modernize the gnulib getopt module to use modern constructs rather than abusing config.h to define an rpl_ prefix. --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org --------------enig7806E1EBC9BCE44EBA8473C8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJNN4GDAAoJEKeha0olJ0NqCJMH/2JYAgSXp71cM6k5ZjK1NQSc kiD3FDSu9gkVM0LiTTC4GJ2k1/yyW/i/k4O3CLldDak7CrbWK+Cmg9HT+ANpo/qy CuTO9MXCquQSFpTiT6Kr0PwSNcYBtfvpEUzyxFy0MrRevFpZwBjRgr7/FxCT3OAc Iomy5IcTLfTGnpopuHsiUtN4tcM2bTGlnszZiepRtYemQLPEdQwvKlcvqC5JI/6p M6iFb6014dxt3iYRC4gVaelmfHHKeJIp41PoyjdWarOypTLvKTN8YFEJRlF/n67O AHFyxlQc+zNiOouyvTsfjiwPN/BY6f9gZd1rgDQPSoXJZICaiF+r0NO38ErNwaI= =A3z8 -----END PGP SIGNATURE----- --------------enig7806E1EBC9BCE44EBA8473C8--