From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: Strange code in xterm.c Date: Mon, 20 Dec 2010 20:58:28 +0100 Message-ID: <4D0FB564.9010909@swipnet.se> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1292875846 21616 80.91.229.12 (20 Dec 2010 20:10:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 20 Dec 2010 20:10:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 20 21:10:41 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PUm46-0005z6-P2 for ged-emacs-devel@m.gmane.org; Mon, 20 Dec 2010 21:10:41 +0100 Original-Received: from localhost ([127.0.0.1]:47796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PUm3y-0003j8-Vm for ged-emacs-devel@m.gmane.org; Mon, 20 Dec 2010 15:10:31 -0500 Original-Received: from [140.186.70.92] (port=38259 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PUltS-0002gK-8g for emacs-devel@gnu.org; Mon, 20 Dec 2010 14:59:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PUlt7-0007Fv-2V for emacs-devel@gnu.org; Mon, 20 Dec 2010 14:59:36 -0500 Original-Received: from smtprelay-h32.telenor.se ([213.150.131.5]:33676) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PUlsg-00073M-Di; Mon, 20 Dec 2010 14:58:50 -0500 Original-Received: from ipb1.telenor.se (ipb1.telenor.se [195.54.127.164]) by smtprelay-h32.telenor.se (Postfix) with ESMTP id 29CA0E9F55; Mon, 20 Dec 2010 20:58:46 +0100 (CET) X-SENDER-IP: [85.225.45.100] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: At4yAMpED01V4S1kPGdsb2JhbACIMJtoDAEBAQE1L78KhUkE X-IronPort-AV: E=Sophos;i="4.60,203,1291590000"; d="scan'208";a="161012742" Original-Received: from c-642de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.100]) by ipb1.telenor.se with ESMTP; 20 Dec 2010 20:58:31 +0100 Original-Received: from zeplin.local (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id 43A537FA05A; Mon, 20 Dec 2010 20:58:30 +0100 (CET) User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; sv-SE; rv:1.9.2.13) Gecko/20101129 Thunderbird/3.1.7 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:133850 Archived-At: It seems I cut away too much when I removed some of the fullscreen stuff. This code looks non-functional, it also doesn't resize the frame. As this code only gets run when there is no window manager present, nobody noticed. I'll clean it up in a day or three. Jan D. Eli Zaretskii skrev 2010-12-20 11.45: > This a large part of the body of x_check_fullscreen: > > int width = FRAME_COLS (f), height = FRAME_LINES (f); > struct x_display_info *dpyinfo = FRAME_X_DISPLAY_INFO (f); > > switch (f->want_fullscreen) > { > /* No difference between these two when there is no WM */ > case FULLSCREEN_BOTH: > case FULLSCREEN_MAXIMIZED: > width = x_display_pixel_width (dpyinfo); > height = x_display_pixel_height (dpyinfo); > break; > case FULLSCREEN_WIDTH: > width = x_display_pixel_width (dpyinfo); > break; > case FULLSCREEN_HEIGHT: > height = x_display_pixel_height (dpyinfo); > } > > if (FRAME_COLS (f) != width || FRAME_LINES (f) != height) > { > change_frame_size (f, height, width, 0, 1, 0); > SET_FRAME_GARBAGED (f); > cancel_mouse_face (f); > } > > Am I missing something, or does it mix up display dimensions in pixels > and in character units?