From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Thien-Thi Nguyen <ttn@gnuvola.org>
Cc: emacs-devel@gnu.org
Subject: Re: Type-error in C code
Date: Sat, 13 Nov 2010 23:23:29 +0100 [thread overview]
Message-ID: <4CDF0FE1.4070404@swipnet.se> (raw)
In-Reply-To: <87lj4xatmu.fsf@ambire.localdomain>
Thien-Thi Nguyen skrev 2010-11-13 20.52:
> () Jan Djärv<jan.h.d@swipnet.se>
> () Sat, 13 Nov 2010 20:19:05 +0100
> However, I fixed the code to use make_fixnum_or_float anyway.
> In the future somebody may come along and wonder why a 32-bit
> number is put in a Lisp integer.
>
> Not if they understand that an Atom is NOT a 32-bit number.
> Perhaps if you revert the change and explain the limits of
> the type in a nice comment, future programmers will not be
> inclined to wonder when they look (only) at the source.
>
> I think routing through ‘make_fixnum_or_float’ is suboptimal.
This code is only used when changing fullscreen or sticky frame parameter.
And that does not happen often. An extra check that ensures the value is
below max fixnum is too small to be worth to optimize away. If atoms are 29
bits, they will be fixnum anyway.
Jan D.
next prev parent reply other threads:[~2010-11-13 22:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 14:02 Type-error in C code Stefan Monnier
2010-11-12 14:21 ` Julien Danjou
2010-11-12 15:12 ` Jan Djärv
2010-11-12 15:22 ` Julien Danjou
2010-11-12 15:28 ` Julien Danjou
2010-11-12 15:32 ` Julien Danjou
2010-11-12 15:48 ` Eli Zaretskii
2010-11-12 15:58 ` Julien Danjou
2010-11-12 16:06 ` John Yates
2010-11-12 16:20 ` Eli Zaretskii
2010-11-12 16:47 ` Andreas Schwab
2010-11-12 19:44 ` Miles Bader
2010-11-12 15:48 ` Eli Zaretskii
2010-11-12 17:13 ` Jan D.
2010-11-12 21:15 ` Thien-Thi Nguyen
2010-11-13 19:19 ` Jan Djärv
2010-11-13 19:52 ` Thien-Thi Nguyen
2010-11-13 22:23 ` Jan Djärv [this message]
2010-11-13 20:38 ` Johan Bockgård
2010-11-14 10:21 ` Jan Djärv
2010-11-12 18:45 ` Andreas Schwab
2010-11-12 21:00 ` Stefan Monnier
2010-11-15 21:11 ` Julien Danjou
2010-11-15 21:19 ` Andreas Schwab
2010-11-16 5:43 ` Stefan Monnier
2010-11-16 7:56 ` Julien Danjou
2010-11-16 9:05 ` Stephen J. Turnbull
2010-11-16 9:28 ` Julien Danjou
2010-11-16 12:11 ` Stephen J. Turnbull
2010-11-16 15:14 ` Stefan Monnier
2010-11-16 15:38 ` Julien Danjou
2010-11-16 17:05 ` Stefan Monnier
2010-11-16 9:36 ` Andreas Schwab
2010-11-13 20:00 ` Julien Danjou
2010-11-15 16:08 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDF0FE1.4070404@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=emacs-devel@gnu.org \
--cc=ttn@gnuvola.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).