unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: Emacs <emacs-devel@gnu.org>
Subject: Re: Configure test for whether localtime caches TZ
Date: Sun, 31 Oct 2010 19:25:29 -0400	[thread overview]
Message-ID: <4CCDFAE9.9090604@cornell.edu> (raw)
In-Reply-To: <sdaalurz91.fsf@fencepost.gnu.org>

On 10/31/2010 2:30 PM, Glenn Morris wrote:
> Ken Brown wrote:
>
>> The configure test for whether localtime caches TZ directly modifies
>> the environment and so (according to POSIX) might produce unreliable
>> results.  Wouldn't it be better to use unsetenv, as in the following
>> patch (against the emacs-23 branch):
>
> Seems better, assuming it is portable. Not worth putting in emacs-23
> IMO though, since the current code has been there for decades with no
> (?) reported problems.

It should be more portable than the existing code.  I've checked it into 
the trunk.



      reply	other threads:[~2010-10-31 23:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-30 18:29 Configure test for whether localtime caches TZ Ken Brown
2010-10-31 18:30 ` Glenn Morris
2010-10-31 23:25   ` Ken Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CCDFAE9.9090604@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).