From: Ken Brown <kbrown@cornell.edu>
To: Dan Nicolaescu <dann@gnu.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: EMACS_GET_TTY_PGRP vs. emacs_get_tty_pgrp
Date: Wed, 20 Oct 2010 16:01:42 -0400 [thread overview]
Message-ID: <4CBF4AA6.3000200@cornell.edu> (raw)
In-Reply-To: <yxqy69soflr.fsf@fencepost.gnu.org>
On 10/20/2010 2:59 PM, Dan Nicolaescu wrote:
> Ken Brown<kbrown@cornell.edu> writes:
>
>> The macro EMACS_GET_TTY_PGRP defined in src/systty.h uses either
>> tcgetpgrp or TIOCGPGRP to get the PGID of a terminal's foreground
>
> It does not:
>
> #ifndef DOS_NT
> #define EMACS_GET_TTY_PGRP(fd, pgid) (*(pgid) = tcgetpgrp ((fd)))
> #define EMACS_SET_TTY_PGRP(fd, pgid) (tcsetpgrp ((fd), *(pgid)))
> #endif /* not DOS_NT */
>
> also, I have a patch to remove this, it's only used in two places, so
> it's not very useful as an abstraction.
Oops. I looked at the emacs-23 branch but not the trunk. Sorry for the
confusion.
But then I still think emacs_get_tty_pgrp in process.c should be changed
so that it works on systems that have tcgetpgrp but not TIOCGPGRP. How
would you recommend handling this? Is it necessary to use conditional
code as in the emacs-23 definition of EMACS_GET_TTY_PGRP, or is it safe
to just always use tcgetpgrp as in the trunk's version of
EMACS_GET_TTY_PGRP?
Ken
next prev parent reply other threads:[~2010-10-20 20:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 14:22 EMACS_GET_TTY_PGRP vs. emacs_get_tty_pgrp Ken Brown
2010-10-20 15:14 ` Andreas Schwab
2010-10-20 18:39 ` Ken Brown
2010-10-20 18:59 ` Dan Nicolaescu
2010-10-20 20:01 ` Ken Brown [this message]
2010-10-20 20:21 ` Eli Zaretskii
2010-10-20 20:28 ` Dan Nicolaescu
2010-10-20 21:28 ` Ken Brown
2010-10-20 21:36 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBF4AA6.3000200@cornell.edu \
--to=kbrown@cornell.edu \
--cc=dann@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).