From: Ken Brown <kbrown@cornell.edu>
To: emacs-devel <emacs-devel@gnu.org>
Subject: EMACS_GET_TTY_PGRP vs. emacs_get_tty_pgrp
Date: Wed, 20 Oct 2010 10:22:13 -0400 [thread overview]
Message-ID: <4CBEFB15.5050303@cornell.edu> (raw)
The macro EMACS_GET_TTY_PGRP defined in src/systty.h uses either
tcgetpgrp or TIOCGPGRP to get the PGID of a terminal's foreground
process group. But src/process.c defines and uses its own
emacs_get_tty_pgrp that only works on systems that have TIOCGPGRP. Is
there a good reason for this? If not, I would like to try to prepare a
patch to change process.c to use the macro instead. This would simplify
the code and would also extend some of the functionality in process.c to
systems that have tcgetpgrp but not TIOCGPGRP.
Ken
next reply other threads:[~2010-10-20 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 14:22 Ken Brown [this message]
2010-10-20 15:14 ` EMACS_GET_TTY_PGRP vs. emacs_get_tty_pgrp Andreas Schwab
2010-10-20 18:39 ` Ken Brown
2010-10-20 18:59 ` Dan Nicolaescu
2010-10-20 20:01 ` Ken Brown
2010-10-20 20:21 ` Eli Zaretskii
2010-10-20 20:28 ` Dan Nicolaescu
2010-10-20 21:28 ` Ken Brown
2010-10-20 21:36 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBEFB15.5050303@cornell.edu \
--to=kbrown@cornell.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).