From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101633: Add fd handling with callbacks to select, dbus needs it for async operation.
Date: Sun, 26 Sep 2010 22:23:16 +0200 [thread overview]
Message-ID: <4C9FABB4.9080607@swipnet.se> (raw)
In-Reply-To: <83ocbkqpph.fsf@gnu.org>
Eli Zaretskii skrev 2010-09-26 21.17:
>> Date: Sun, 26 Sep 2010 21:07:32 +0200
>> From: Jan Djärv<jan.h.d@swipnet.se>
>> CC: emacs-devel@gnu.org
>>
>>> The changes that remove the "#ifdef subprocesses" conditionals will
>>> probably break the MSDOS build, because input_wait_mask etc. are only
>>> defined "#ifdef subprocesses". The functions
>>> add_keyboard_wait_descriptor and delete_keyboard_wait_descriptor are
>>> supposed to be no-ops for the MSDOS build.
>>
>> We need another ifdef then as dbus and for example session file descriptors
>> have nothing to do with subprocesses. #ifndef MSDOS perhaps?
>
> The only Emacs build that doesn't have `subprocesses' #define'd is the
> MSDOS build. Using "#ifdef subprocesses" is just slightly less ugly
> then OS-dependent #define, but otherwise it is functionally identical
> to "#ifndef MSDOS".
>
> So I don't think we need another ifdef.
Ok, I put it back.
Jan D.
next prev parent reply other threads:[~2010-09-26 20:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Ozur1-0004Ag-MZ@eggs.gnu.org>
2010-09-26 18:28 ` [Emacs-diffs] /srv/bzr/emacs/trunk r101633: Add fd handling with callbacks to select, dbus needs it for async operation Eli Zaretskii
2010-09-26 19:07 ` Jan Djärv
2010-09-26 19:17 ` Eli Zaretskii
2010-09-26 20:23 ` Jan Djärv [this message]
2010-09-26 22:00 ` Eli Zaretskii
[not found] <E1Ozuqt-0004W5-KB@internal.in.savannah.gnu.org>
2010-09-26 19:49 ` Juanma Barranquero
2010-09-26 20:50 ` Jan Djärv
2010-09-26 21:05 ` Juanma Barranquero
2010-09-26 21:59 ` Eli Zaretskii
2010-09-27 6:30 ` Jan Djärv
2010-09-27 7:43 ` Eli Zaretskii
2010-09-27 8:23 ` Jan Djärv
2010-09-27 8:40 ` Eli Zaretskii
2010-09-27 9:09 ` Jan Djärv
2010-09-27 10:33 ` Dan Nicolaescu
2010-09-27 11:53 ` Jan Djärv
2010-09-27 20:43 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9FABB4.9080607@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).